[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2 v16] fsdev: add IO throttle support to fsdev
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 1/2 v16] fsdev: add IO throttle support to fsdev devices |
Date: |
Wed, 22 Feb 2017 11:04:42 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 |
On 02/22/2017 10:59 AM, Greg Kurz wrote:
>>>> I see these parameter names as stable. There is little risk that they
>>>> would change.
>>
>> We just need to be sure that when we do add QMP, that it doesn't use
>> names that differ from the command line (blockdev is an example where we
>> weren't careful in 2.8, and had to rename things in 2.9 to be
>> consistent, and I want to avoid repeating that mistake).
>>
>
> Can you provide some pointers on what had to be fixed in blockdev ?
See for example commits f67409a, 4230e5d, 1a417e4 showing several cases
where we had to fix up inconsistencies.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH 1/2 v16] fsdev: add IO throttle support to fsdev devices, (continued)
- Re: [Qemu-devel] [PATCH 1/2 v16] fsdev: add IO throttle support to fsdev devices, Alberto Garcia, 2017/02/03
- Re: [Qemu-devel] [PATCH 1/2 v16] fsdev: add IO throttle support to fsdev devices, Eric Blake, 2017/02/06
- Re: [Qemu-devel] [PATCH 1/2 v16] fsdev: add IO throttle support to fsdev devices, Greg Kurz, 2017/02/06
- Re: [Qemu-devel] [PATCH 1/2 v16] fsdev: add IO throttle support to fsdev devices, Greg Kurz, 2017/02/07
- Re: [Qemu-devel] [PATCH 1/2 v16] fsdev: add IO throttle support to fsdev devices, Eric Blake, 2017/02/07
- Re: [Qemu-devel] [PATCH 1/2 v16] fsdev: add IO throttle support to fsdev devices, Greg Kurz, 2017/02/07
- Re: [Qemu-devel] [PATCH 1/2 v16] fsdev: add IO throttle support to fsdev devices, Stefan Hajnoczi, 2017/02/14
- Re: [Qemu-devel] [PATCH 1/2 v16] fsdev: add IO throttle support to fsdev devices, Greg Kurz, 2017/02/22
- Re: [Qemu-devel] [PATCH 1/2 v16] fsdev: add IO throttle support to fsdev devices, Eric Blake, 2017/02/22
- Re: [Qemu-devel] [PATCH 1/2 v16] fsdev: add IO throttle support to fsdev devices, Greg Kurz, 2017/02/22
- Re: [Qemu-devel] [PATCH 1/2 v16] fsdev: add IO throttle support to fsdev devices,
Eric Blake <=
- Re: [Qemu-devel] [PATCH 1/2 v16] fsdev: add IO throttle support to fsdev devices, Fam Zheng, 2017/02/07
- Re: [Qemu-devel] [PATCH 1/2 v16] fsdev: add IO throttle support to fsdev devices, Pradeep Jagadeesh, 2017/02/07
[Qemu-devel] [PATCH 2/2 v16] throttle: factor out duplicate code, Pradeep Jagadeesh, 2017/02/03
- Re: [Qemu-devel] [PATCH 2/2 v16] throttle: factor out duplicate code, Alberto Garcia, 2017/02/03
- Re: [Qemu-devel] [PATCH 2/2 v16] throttle: factor out duplicate code, Pradeep Jagadeesh, 2017/02/03
- Re: [Qemu-devel] [PATCH 2/2 v16] throttle: factor out duplicate code, Alberto Garcia, 2017/02/03
- Re: [Qemu-devel] [PATCH 2/2 v16] throttle: factor out duplicate code, Pradeep Jagadeesh, 2017/02/03
- Re: [Qemu-devel] [PATCH 2/2 v16] throttle: factor out duplicate code, Alberto Garcia, 2017/02/03
- Re: [Qemu-devel] [PATCH 2/2 v16] throttle: factor out duplicate code, Pradeep Jagadeesh, 2017/02/03
Re: [Qemu-devel] [PATCH 2/2 v16] throttle: factor out duplicate code, Greg Kurz, 2017/02/06