[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 0/3] add sdhost and gpio controllers to the b
From: |
no-reply |
Subject: |
Re: [Qemu-devel] [PATCH v2 0/3] add sdhost and gpio controllers to the bcm2835 platform |
Date: |
Wed, 22 Feb 2017 03:31:25 -0800 (PST) |
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Subject: [Qemu-devel] [PATCH v2 0/3] add sdhost and gpio controllers to the
bcm2835 platform
Message-id: address@hidden
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
- [tag update] patchew/address@hidden -> patchew/address@hidden
* [new tag] patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
a4811c2 bcm2835: add sdhost and gpio controllers
7e38334 bcm2835_gpio: add bcm2835 gpio controller
af824c3 bcm2835_sdhost: add bcm2835 sdhost controller
=== OUTPUT BEGIN ===
Checking PATCH 1/3: bcm2835_sdhost: add bcm2835 sdhost controller...
Checking PATCH 2/3: bcm2835_gpio: add bcm2835 gpio controller...
ERROR: space required before the open parenthesis '('
#97: FILE: hw/gpio/bcm2835_gpio.c:68:
+ if(kid == NULL) {
total: 1 errors, 0 warnings, 403 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 3/3: bcm2835: add sdhost and gpio controllers...
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden