[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 4/5] slirp: VMStatify socket level
From: |
Juan Quintela |
Subject: |
Re: [Qemu-devel] [PATCH v4 4/5] slirp: VMStatify socket level |
Date: |
Tue, 21 Feb 2017 15:03:56 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) |
"Dr. David Alan Gilbert (git)" <address@hidden> wrote:
> From: "Dr. David Alan Gilbert" <address@hidden>
>
> Working up the stack, this replaces the slirp_socket_load/save
> with VMState definitions.
>
> A place holder for IPv6 support is added as a comment; it needs
> testing once the rest of the IPv6 code is there.
>
> Signed-off-by: Dr. David Alan Gilbert <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>
> +/* Win has a signed family number */
> +#define VMSTATE_SS_FAMILY(f, s) VMSTATE_INT16(f, s)
Great!
Just hope that there is no 32000 families soon :-)
> +#if 0
> + /* Untested: Needs checking by someone with IPv6 test */
> + VMSTATE_BUFFER_TEST(sin6.sin6_addr, union slirp_sockaddr,
> + slirp_family_inet6),
> + VMSTATE_UINT16_TEST(sin6.sin6_port, union slirp_sockaddr,
> + slirp_family_inet6),
> + VMSTATE_UINT32_TEST(sin6.sin6_flowinfo, union slirp_sockaddr,
> + slirp_family_inet6),
> + VMSTATE_UINT32_TEST(sin6.sin6_scope_id, union slirp_sockaddr,
> + slirp_family_inet6),
> +#endif
I think this is wrong, we have different fieldbs depending in if it is
ipv6 or not?
Later, Juan.
- [Qemu-devel] [PATCH v4 0/5] SLIRP VMStatification, Dr. David Alan Gilbert (git), 2017/02/20
- [Qemu-devel] [PATCH v4 3/5] slirp: Common lhost/fhost union, Dr. David Alan Gilbert (git), 2017/02/20
- [Qemu-devel] [PATCH v4 4/5] slirp: VMStatify socket level, Dr. David Alan Gilbert (git), 2017/02/20
- Re: [Qemu-devel] [PATCH v4 4/5] slirp: VMStatify socket level,
Juan Quintela <=
- Re: [Qemu-devel] [PATCH v4 4/5] slirp: VMStatify socket level, Dr. David Alan Gilbert, 2017/02/21
- Re: [Qemu-devel] [PATCH v4 4/5] slirp: VMStatify socket level, Dr. David Alan Gilbert, 2017/02/23
- Re: [Qemu-devel] [PATCH v4 4/5] slirp: VMStatify socket level, Daniel P. Berrange, 2017/02/23
- Re: [Qemu-devel] [PATCH v4 4/5] slirp: VMStatify socket level, Dr. David Alan Gilbert, 2017/02/23
- Re: [Qemu-devel] [PATCH v4 4/5] slirp: VMStatify socket level, Samuel Thibault, 2017/02/26
- Re: [Qemu-devel] [PATCH v4 4/5] slirp: VMStatify socket level, Samuel Thibault, 2017/02/26
- Re: [Qemu-devel] [PATCH v4 4/5] slirp: VMStatify socket level, Dr. David Alan Gilbert, 2017/02/28
- Re: [Qemu-devel] [PATCH v4 4/5] slirp: VMStatify socket level, Samuel Thibault, 2017/02/28
- Re: [Qemu-devel] [PATCH v4 4/5] slirp: VMStatify socket level, Dr. David Alan Gilbert, 2017/02/28
- Re: [Qemu-devel] [PATCH v4 4/5] slirp: VMStatify socket level, Samuel Thibault, 2017/02/28