Re: [Qemu-devel] [PATCH] risu-m68k: update fpregs

[Laurent Vivier]

Le 20/02/2017 à 13:14, Peter Maydell a écrit :
> On 19 February 2017 at 20:02, Laurent Vivier <address@hidden> wrote:
>> f_fpregs is a 2d array, not 1d:
>>
>>  typedef struct fpregset
>>  {
>>    int f_pcr;
>>    int f_psr;
>>    int f_fpiaddr;
>>  #ifdef __mcoldfire__
>>    int f_fpregs[8][2];
>>  #else
>>    int f_fpregs[8][3];
>>  #endif
>>  } fpregset_t;
>>
>> For the moment, we don't manage ColdFire case, only 680x0.
>>
>> Signed-off-by: Laurent Vivier <address@hidden>
> 
> Thanks; applied to target-arm.next.
> 
> I've also pushed out support for building risu into a separate
> build directory, and a 'build-all-archs' script that will
> build every target CPU arch that you have a cross compiler
> installed for (Debian and Ubuntu package cross compilers for
> everything, helpfully).

Thank you.

I have some problems with risugen since some functions have been moved
to common:

$ ./risugen --numinsns 10000 --pattern ABCD m68k.risu ABCD.out
Generating code using patterns: ABCD M68000...
Syntax error detected evaluating ABCD M68000 constraints string:
    ]
{                         write_movb_di($Dx, rand(10) | (rand(10) <<
4));                         write_movb_di($Dy, rand(10) | (rand(10) <<
4));                         1;                      }
Undefined subroutine &risugen_common::write_movb_di called at (eval 5)
line 1.

If I add "risugen_m68k::" to the function name, it works. But is there
better solution to fix that instead of updating all the calls in
m68k.risu for functions found in risugen_m68k.pm?

Thanks,
Laurent