Re: [Qemu-devel] [PATCH 04/24] tests/test-cutils: Clean up qemu_strtoul() result checks

[Markus Armbruster]

Eric Blake <address@hidden> writes:

> On 02/14/2017 04:25 AM, Markus Armbruster wrote:
>> Use unsigned comparisons to check the result of qemu_strtoul() and
>> strtoull().
>> 
>> Signed-off-by: Markus Armbruster <address@hidden>
>> ---
>>  tests/test-cutils.c | 60 
>> ++++++++++++++++++++++++++---------------------------
>>  1 file changed, 30 insertions(+), 30 deletions(-)
>> 
>
> No real difference except when the test fails (better printed result if
> the number being printed exceeds the max signed counterpart value), but
> never hurts to be more precise.

Sadly, my version of glib prints signed all the same.

I'll use g_assert_cmphex() where useful in v2.

> Reviewed-by: Eric Blake <address@hidden>

Thanks!