[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v15 08/25] block: introduce auto-loading bitmaps
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH v15 08/25] block: introduce auto-loading bitmaps |
Date: |
Thu, 16 Feb 2017 12:49:44 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 16.02.2017 um 12:25 hat Kevin Wolf geschrieben:
> Am 15.02.2017 um 11:10 hat Vladimir Sementsov-Ogievskiy geschrieben:
> > Auto loading bitmaps are bitmaps stored in the disk image, which should
> > be loaded when the image is opened and become BdrvDirtyBitmaps for the
> > corresponding drive.
> >
> > Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> > Reviewed-by: John Snow <address@hidden>
> > Reviewed-by: Max Reitz <address@hidden>
>
> Why do we need a new BlockDriver callback and special code for it in
> bdrv_open_common()? The callback is only ever called immediately after
> .bdrv_open/.bdrv_file_open, so can't the drivers just do this internally
> in their .bdrv_open implementation? Even more so because qcow2 is the
> only driver that supports this callback.
Actually, don't we have to call this in qcow2_invalidate_cache()?
Currently, I think, after a migration, the autoload bitmaps aren't
loaded.
By moving the qcow2_load_autoloading_dirty_bitmaps() call to
qcow2_open(), this would be fixed.
Kevin
- [Qemu-devel] [PATCH v15 00/25] qcow2: persistent dirty bitmaps, Vladimir Sementsov-Ogievskiy, 2017/02/15
- [Qemu-devel] [PATCH v15 05/25] block: fix bdrv_dirty_bitmap_granularity signature, Vladimir Sementsov-Ogievskiy, 2017/02/15
- [Qemu-devel] [PATCH v15 20/25] qcow2-refcount: rename inc_refcounts() and make it public, Vladimir Sementsov-Ogievskiy, 2017/02/15
- [Qemu-devel] [PATCH v15 08/25] block: introduce auto-loading bitmaps, Vladimir Sementsov-Ogievskiy, 2017/02/15
- Re: [Qemu-devel] [PATCH v15 08/25] block: introduce auto-loading bitmaps, Kevin Wolf, 2017/02/16
- Re: [Qemu-devel] [PATCH v15 08/25] block: introduce auto-loading bitmaps,
Kevin Wolf <=
- Re: [Qemu-devel] [PATCH v15 08/25] block: introduce auto-loading bitmaps, Vladimir Sementsov-Ogievskiy, 2017/02/17
- Re: [Qemu-devel] [PATCH v15 08/25] block: introduce auto-loading bitmaps, Kevin Wolf, 2017/02/17
- Re: [Qemu-devel] [PATCH v15 08/25] block: introduce auto-loading bitmaps, Vladimir Sementsov-Ogievskiy, 2017/02/17
- Re: [Qemu-devel] [PATCH v15 08/25] block: introduce auto-loading bitmaps, Kevin Wolf, 2017/02/17
- Re: [Qemu-devel] [PATCH v15 08/25] block: introduce auto-loading bitmaps, Denis V. Lunev, 2017/02/17
- Re: [Qemu-devel] [PATCH v15 08/25] block: introduce auto-loading bitmaps, Kevin Wolf, 2017/02/17
- Re: [Qemu-devel] [PATCH v15 08/25] block: introduce auto-loading bitmaps, Denis V. Lunev, 2017/02/17
- Re: [Qemu-devel] [PATCH v15 08/25] block: introduce auto-loading bitmaps, Kevin Wolf, 2017/02/17
- Re: [Qemu-devel] [PATCH v15 08/25] block: introduce auto-loading bitmaps, Vladimir Sementsov-Ogievskiy, 2017/02/17
- Re: [Qemu-devel] [PATCH v15 08/25] block: introduce auto-loading bitmaps, Denis V. Lunev, 2017/02/18