[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 0/5] SLIRP VMStatification
From: |
no-reply |
Subject: |
Re: [Qemu-devel] [PATCH v3 0/5] SLIRP VMStatification |
Date: |
Wed, 15 Feb 2017 10:31:08 -0800 (PST) |
Hi,
Your series seems to have some coding style problems. See output below for
more information:
Type: series
Subject: [Qemu-devel] [PATCH v3 0/5] SLIRP VMStatification
Message-id: address@hidden
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag] patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
158a5ce slirp: VMStatify remaining except for loop
c9a77f6 slirp: VMStatify socket level
a3add04 slirp: Common lhost/fhost union
0c4b4ae slirp: VMStatify sbuf
b9e6cbb slirp: VMState conversion; tcpcb
=== OUTPUT BEGIN ===
Checking PATCH 1/5: slirp: VMState conversion; tcpcb...
ERROR: code indent should never use tabs
#211: FILE: slirp/tcp_var.h:51:
+^Iuint8_t t_force;^I^I/* 1 if forcing out a byte */$
ERROR: code indent should never use tabs
#221: FILE: slirp/tcp_var.h:112:
+^Iuint8_t^It_oobflags;^I^I/* have some */$
ERROR: code indent should never use tabs
#222: FILE: slirp/tcp_var.h:113:
+^Iuint8_t^It_iobc;^I^I^I/* input character */$
total: 3 errors, 0 warnings, 195 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 2/5: slirp: VMStatify sbuf...
ERROR: code indent should never use tabs
#26: FILE: slirp/sbuf.h:15:
+^Iuint32_t sb_cc;^I^I/* actual chars in buffer */$
ERROR: code indent should never use tabs
#27: FILE: slirp/sbuf.h:16:
+^Iuint32_t sb_datalen;^I/* Length of data */$
total: 2 errors, 0 warnings, 155 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 3/5: slirp: Common lhost/fhost union...
Checking PATCH 4/5: slirp: VMStatify socket level...
ERROR: if this code is redundant consider removing it
#86: FILE: slirp/slirp.c:1286:
+#if 0
total: 1 errors, 0 warnings, 206 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 5/5: slirp: VMStatify remaining except for loop...
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden
- [Qemu-devel] [PATCH v3 0/5] SLIRP VMStatification, Dr. David Alan Gilbert (git), 2017/02/15
- [Qemu-devel] [PATCH v3 1/5] slirp: VMState conversion; tcpcb, Dr. David Alan Gilbert (git), 2017/02/15
- [Qemu-devel] [PATCH v3 2/5] slirp: VMStatify sbuf, Dr. David Alan Gilbert (git), 2017/02/15
- [Qemu-devel] [PATCH v3 3/5] slirp: Common lhost/fhost union, Dr. David Alan Gilbert (git), 2017/02/15
- [Qemu-devel] [PATCH v3 4/5] slirp: VMStatify socket level, Dr. David Alan Gilbert (git), 2017/02/15
- [Qemu-devel] [PATCH v3 5/5] slirp: VMStatify remaining except for loop, Dr. David Alan Gilbert (git), 2017/02/15
- Re: [Qemu-devel] [PATCH v3 0/5] SLIRP VMStatification,
no-reply <=
- Re: [Qemu-devel] [PATCH v3 0/5] SLIRP VMStatification, no-reply, 2017/02/15