[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] audio: make audio poll timer deterministic
From: |
Yurii Zubrytskyi |
Subject: |
Re: [Qemu-devel] [PATCH] audio: make audio poll timer deterministic |
Date: |
Mon, 13 Feb 2017 10:40:30 -0800 |
Hi,
It looks to me that this behavior can be achieved with "timer_mod_anticipate()"
function instead of a separate check.
On Sun, Feb 12, 2017 at 9:04 PM, Pavel Dovgalyuk <address@hidden> wrote:
> Ping?
>
> Pavel Dovgalyuk
>
>
> > -----Original Message-----
> > From: Pavel Dovgalyuk [mailto:address@hidden
> > Sent: Tuesday, January 31, 2017 2:59 PM
> > To: address@hidden
> > Cc: address@hidden; address@hidden; address@hidden
> > Subject: [PATCH] audio: make audio poll timer deterministic
> >
> > This patch changes resetting strategy of the audio polling timer.
> > It does not change expiration time if the timer is already set.
> >
> > Signed-off-by: Pavel Dovgalyuk <address@hidden>
> > ---
> > audio/audio.c | 6 ++++--
> > 1 file changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/audio/audio.c b/audio/audio.c
> > index c845a44..1ee95a5 100644
> > --- a/audio/audio.c
> > +++ b/audio/audio.c
> > @@ -1112,8 +1112,10 @@ static int audio_is_timer_needed (void)
> > static void audio_reset_timer (AudioState *s)
> > {
> > if (audio_is_timer_needed ()) {
> > - timer_mod (s->ts,
> > - qemu_clock_get_ns(QEMU_CLOCK_VIRTUAL) + conf.period.ticks);
> > + if (!timer_pending(s->ts)) {
> > + timer_mod (s->ts,
> > + qemu_clock_get_ns(QEMU_CLOCK_VIRTUAL) +
> conf.period.ticks);
> > + }
> > }
> > else {
> > timer_del (s->ts);
>
>
>
>
--
Thanks, Yurii