Re: [Qemu-devel] [PATCH v2] linux-user: Add FICLONE and FICLONERANGE ioctls

[Laurent Vivier]

Le 11/02/2017 à 23:26, Helge Deller a écrit :
> Add missing FICLONE and FICLONERANGE ioctls.
> 
> Changes to v1:
> - Added STRUCT_file_clone_range as suggested by Laurent Vivier
> 
> Signed-off-by: Helge Deller <address@hidden>

Reviewed-by: Laurent Vivier <address@hidden>

> 
> diff --git a/linux-user/ioctls.h b/linux-user/ioctls.h
> index 2f6e85b..e6997ff 100644
> --- a/linux-user/ioctls.h
> +++ b/linux-user/ioctls.h
> @@ -112,6 +112,11 @@
>  #ifdef FIBMAP
>       IOCTL(FIBMAP, IOC_W | IOC_R, MK_PTR(TYPE_LONG))
>  #endif
> +#ifdef FICLONE
> +     IOCTL(FICLONE, IOC_W, TYPE_INT)
> +     IOCTL(FICLONERANGE, IOC_W, MK_PTR(MK_STRUCT(STRUCT_file_clone_range)))
> +#endif
> +
>  #ifdef FIGETBSZ
>       IOCTL(FIGETBSZ, IOC_R, MK_PTR(TYPE_LONG))
>  #endif
> diff --git a/linux-user/syscall_defs.h b/linux-user/syscall_defs.h
> index 4442c22..72ca5b1 100644
> --- a/linux-user/syscall_defs.h
> +++ b/linux-user/syscall_defs.h
> @@ -1086,6 +1086,10 @@ struct target_pollfd {
>  
>  #define TARGET_FIBMAP     TARGET_IO(0x00,1)  /* bmap access */
>  #define TARGET_FIGETBSZ   TARGET_IO(0x00,2)  /* get the block size used for 
> bmap */
> +
> +#define TARGET_FICLONE    TARGET_IOW(0x94, 9, int)
> +#define TARGET_FICLONERANGE TARGET_IOW(0x94, 13, struct file_clone_range)
> +
>  /* Note that the ioctl numbers claim type "long" but the actual type
>   * used by the kernel is "int".
>   */
> diff --git a/linux-user/syscall_types.h b/linux-user/syscall_types.h
> index 2b8c0c6..24631b0 100644
> --- a/linux-user/syscall_types.h
> +++ b/linux-user/syscall_types.h
> @@ -232,6 +232,12 @@ STRUCT(dm_target_versions,
>  STRUCT(dm_target_msg,
>         TYPE_ULONGLONG) /* sector */
>  
> +STRUCT(file_clone_range,
> +       TYPE_LONGLONG, /* src_fd */
> +       TYPE_ULONGLONG, /* src_offset */
> +       TYPE_ULONGLONG, /* src_length */
> +       TYPE_ULONGLONG) /* dest_offset */
> +
>  STRUCT(fiemap_extent,
>         TYPE_ULONGLONG, /* fe_logical */
>         TYPE_ULONGLONG, /* fe_physical */
>