[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] net: Turn simple union NetLegacyOptions int
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 2/2] net: Turn simple union NetLegacyOptions into a flat union |
Date: |
Wed, 8 Feb 2017 13:22:54 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 |
On 02/08/2017 10:04 AM, Markus Armbruster wrote:
> Simple unions are simpler than flat unions in the schema, but more
> complicated in C and on the QMP wire: there's extra indirection in C
> and extra nesting on the wire, both pointless. They're best avoided
> in new code.
>
> NetLegacyOptions isn't new, but it's only used internally, not in QMP.
> Convert it to a flat union.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> net/net.c | 44 ++++++++++++++++++++++----------------------
> qapi-schema.json | 9 +++++++++
> 2 files changed, 31 insertions(+), 22 deletions(-)
>
> +++ b/qapi-schema.json
> @@ -3934,6 +3934,13 @@
> 'opts': 'NetLegacyOptions' } }
>
> ##
> +# @NetLegacyOptionsType:
> +##
Same question as previous patch about a 'Since: 1.2' designation. Same
end result of:
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature