[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 21/28] tests: fix virtio-9p-test leaks
From: |
Greg Kurz |
Subject: |
Re: [Qemu-devel] [PATCH 21/28] tests: fix virtio-9p-test leaks |
Date: |
Tue, 7 Feb 2017 17:43:05 +0100 |
On Tue, 7 Feb 2017 17:52:04 +0400
Marc-André Lureau <address@hidden> wrote:
> Spotted by ASAN.
>
> Cc: "Aneesh Kumar K.V" <address@hidden>
> Cc: Greg Kurz <address@hidden>
> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
I was a bit confused at first but hopefully I could find the definition of
qvirtio_pci_device_free() in patch 08/28 :)
Reviewed-by: Greg Kurz <address@hidden>
> tests/virtio-9p-test.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/virtio-9p-test.c b/tests/virtio-9p-test.c
> index 9556291567..43a1ad813f 100644
> --- a/tests/virtio-9p-test.c
> +++ b/tests/virtio-9p-test.c
> @@ -80,7 +80,7 @@ static void qvirtio_9p_pci_stop(QVirtIO9P *v9p)
> {
> qvirtqueue_cleanup(v9p->dev->bus, v9p->vq, v9p->qs->alloc);
> qvirtio_pci_device_disable(container_of(v9p->dev, QVirtioPCIDevice,
> vdev));
> - g_free(v9p->dev);
> + qvirtio_pci_device_free((QVirtioPCIDevice *)v9p->dev);
> qvirtio_9p_stop(v9p);
> }
>
- [Qemu-devel] [PATCH 13/28] tests: fix ipmi-bt-test leak, (continued)
- [Qemu-devel] [PATCH 13/28] tests: fix ipmi-bt-test leak, Marc-André Lureau, 2017/02/07
- [Qemu-devel] [PATCH 15/28] tests: fix eepro100-test leak, Marc-André Lureau, 2017/02/07
- [Qemu-devel] [PATCH 14/28] pc: pcihp: avoid adding ACPI_PCIHP_PROP_BSEL twice, Marc-André Lureau, 2017/02/07
- [Qemu-devel] [PATCH 16/28] tests: fix tco-test leaks, Marc-André Lureau, 2017/02/07
- [Qemu-devel] [PATCH 17/28] tests: fix e1000-test leak, Marc-André Lureau, 2017/02/07
- [Qemu-devel] [PATCH 18/28] tests: fix i440fx-test leaks, Marc-André Lureau, 2017/02/07
- [Qemu-devel] [PATCH 19/28] tests: fix e1000e leaks, Marc-André Lureau, 2017/02/07
- [Qemu-devel] [PATCH 20/28] tests: fix virtio-scsi-test leak, Marc-André Lureau, 2017/02/07
- [Qemu-devel] [PATCH 21/28] tests: fix virtio-9p-test leaks, Marc-André Lureau, 2017/02/07
- Re: [Qemu-devel] [PATCH 21/28] tests: fix virtio-9p-test leaks,
Greg Kurz <=
- [Qemu-devel] [PATCH 22/28] bus: do not unref hotplug handler, Marc-André Lureau, 2017/02/07
- [Qemu-devel] [PATCH 23/28] usb: replace handle_destroy with unrealize, Marc-André Lureau, 2017/02/07
- [Qemu-devel] [PATCH 24/28] usb: release the created buses, Marc-André Lureau, 2017/02/07
- [Qemu-devel] [PATCH 26/28] tests: fix usb-test leaks, Marc-André Lureau, 2017/02/07
- [Qemu-devel] [PATCH 25/28] tests: allows to run single test in usb-hcd-ehci-test, Marc-André Lureau, 2017/02/07
- [Qemu-devel] [PATCH 27/28] tests: add specialized device_find function, Marc-André Lureau, 2017/02/07
- [Qemu-devel] [PATCH 28/28] tests: fix virtio-blk-test leaks, Marc-André Lureau, 2017/02/07
- Re: [Qemu-devel] [PATCH 00/28] Various memory leak fixes, no-reply, 2017/02/07