[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v7 2/2] gdbstub: Fix vCont behaviour
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH v7 2/2] gdbstub: Fix vCont behaviour |
|
Date: |
Tue, 7 Feb 2017 16:10:13 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 |
On 07/02/2017 10:59, Claudio Imbrenda wrote:
> static inline int cpu_index(CPUState *cpu)
> {
> #if defined(CONFIG_USER_ONLY)
> return cpu->host_tid;
> #else
> return cpu->cpu_index + 1;
> #endif
> }
>
>
> maybe that can just become newstates[cpu->cpu_index] = 1 ?
> (since we're not in CONFIG_USER_ONLY anyway)
Yes, I think it should be like that, especially if in the future we want
to support CONFIG_USER_ONLY it makes no sense to use host PIDs.
Paolo