[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V2 02/10] qemu-clk: allow to add a clock to a de
|
From: |
Frederic Konrad |
|
Subject: |
Re: [Qemu-devel] [PATCH V2 02/10] qemu-clk: allow to add a clock to a device |
|
Date: |
Tue, 7 Feb 2017 10:49:10 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2 |
On 02/07/2017 10:31 AM, Cédric Le Goater wrote:
> On 02/07/2017 10:22 AM, Frederic Konrad wrote:
>>> I see how these routines are used in patch 10/10. But if we were
>>> open coding device CRF_APB, I don't think we would need them at
>>> all and it would make the code a little simple IMHO.
>> What do you mean by open coding?
>
> I mean to externalize the definition of the objects in a
> header file.
>
> Then you can replace the type 'Object *' of the attribute
> holding a reference to an instance by a non pointer type.
>
> Anyhow, I think we need to replace object_new() by
> object_initialize() for QOM, and so we need to expose a
> little more the object internals.
Ok got you.
I'll take a look.
Thanks,
Fred
>
> Thanks,
>
> C.
>
>