Re: [Qemu-devel] [PATCH v6 07/18] intel_iommu: fix trace for inv desc handling

[Peter Xu]

On Tue, Feb 07, 2017 at 01:38:30PM +0800, Jason Wang wrote:
> 
> 
> On 2017年02月03日 16:22, Peter Xu wrote:
> >VT-d codes are still using static DEBUG_INTEL_IOMMU macro. That's not
> >good, and we should end the day when we need to recompile the code
> >before getting useful debugging information for vt-d. Time to switch to
> >the trace system.
> 
> Looks like we end up with using debug macros and tracepoints at the same
> time (even with patch 8), this will cause even more troubles.

I was converting debug macros into traces gradually rather than in a
single big patch. Those ones that were converted are possibly useful
for debugging of current series. I can do the rest of convertion in
another standalone patch after this series.

> 
> 
> >This is the first patch to do it.
> >
> >Generally, the rule of mine is:
> >
> >- for the old GENERAL typed message, I use trace_vtd_err*() in general.
> >
> >- for the non-GENERAL typed messages, convert into specified trace_*().
> >
> >- for useless DPRINTFs, I removed them.
> >
> >Signed-off-by: Peter Xu<address@hidden>
> >---
> 
> The title is a little bit confusing, this in fact convert from debug macros
> to tracepoints.

I'll find a better subject. Thanks,

-- peterx