Re: [Qemu-devel] [PATCH v5 02/10] linker-loader: Add new 'write pointer' command

[Michael S. Tsirkin]

On Mon, Feb 06, 2017 at 09:16:25AM -0800, Ben Warren wrote:
> >> @@ -257,8 +263,11 @@ void bios_linker_loader_add_pointer(BIOSLinker 
> >> *linker,
> >>     const BiosLinkerFileEntry *source_file =
> >>         bios_linker_find_file(linker, src_file);
> >> 
> >> -    assert(dst_patched_offset < dst_file->blob->len);
> >> -    assert(dst_patched_offset + dst_patched_size <= dst_file->blob->len);
> >> +    /* dst_file need not exist if writing back */
> > 
> > Why not?
> Because WRITE_POINTER can be called without having first called
> ALLOCATE.  In the Vm Generation ID example, there’s no reason for BIOS
> to allocate memory for the address fw_cfg, since it’s a construct that
> only matters to QEMU.  This is something that was requested by Laszlo.

Well all other commands require you to first allocate.
How does bios know e.g. which zone to put it in then?

I don't like the asymmetry ... Laszlo?

-- 
MST