[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 6/9] xhci: don't kick in xhci_submit and xhci_fire_ct
From: |
Gerd Hoffmann |
Subject: |
[Qemu-devel] [PULL 6/9] xhci: don't kick in xhci_submit and xhci_fire_ctl_transfer |
Date: |
Mon, 6 Feb 2017 12:28:18 +0100 |
xhci_submit and xhci_fire_ctl_transfer are is called from
xhci_kick_epctx processing loop only, so there is no need to call
xhci_kick_epctx make sure processing continues. Also eecursive calls
into xhci_kick_epctx can cause trouble.
Drop the xhci_kick_epctx calls.
Cc: address@hidden
Fixes: 94b037f2a451b3dc855f9f2c346e5049a361bd55
Reported-by: Fabian Lesniak <address@hidden>
Signed-off-by: Gerd Hoffmann <address@hidden>
Message-id: address@hidden
---
hw/usb/hcd-xhci.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c
index 7e863d3..f89d8da 100644
--- a/hw/usb/hcd-xhci.c
+++ b/hw/usb/hcd-xhci.c
@@ -2001,11 +2001,7 @@ static int xhci_fire_ctl_transfer(XHCIState *xhci,
XHCITransfer *xfer)
xfer->packet.parameter = trb_setup->parameter;
usb_handle_packet(xfer->packet.ep->dev, &xfer->packet);
-
xhci_try_complete_packet(xfer);
- if (!xfer->running_async && !xfer->running_retry) {
- xhci_kick_epctx(xfer->epctx, 0);
- }
return 0;
}
@@ -2105,11 +2101,7 @@ static int xhci_submit(XHCIState *xhci, XHCITransfer
*xfer, XHCIEPContext *epctx
return -1;
}
usb_handle_packet(xfer->packet.ep->dev, &xfer->packet);
-
xhci_try_complete_packet(xfer);
- if (!xfer->running_async && !xfer->running_retry) {
- xhci_kick_epctx(xfer->epctx, xfer->streamid);
- }
return 0;
}
--
1.8.3.1
- [Qemu-devel] [PULL 0/9] usb: various bugfixes, mostly xhci., Gerd Hoffmann, 2017/02/06
- [Qemu-devel] [PULL 8/9] usb: ccid: check ccid apdu length, Gerd Hoffmann, 2017/02/06
- [Qemu-devel] [PULL 3/9] usb: accept usb3 control requests, Gerd Hoffmann, 2017/02/06
- [Qemu-devel] [PULL 4/9] xhci: only free completed transfers, Gerd Hoffmann, 2017/02/06
- [Qemu-devel] [PULL 1/9] hw/usb/dev-hid: Improve guest compatibility of usb-tablet, Gerd Hoffmann, 2017/02/06
- [Qemu-devel] [PULL 7/9] xhci: guard xhci_kick_epctx against recursive calls, Gerd Hoffmann, 2017/02/06
- [Qemu-devel] [PULL 5/9] xhci: rename xhci_complete_packet to xhci_try_complete_packet, Gerd Hoffmann, 2017/02/06
- [Qemu-devel] [PULL 6/9] xhci: don't kick in xhci_submit and xhci_fire_ctl_transfer,
Gerd Hoffmann <=
- [Qemu-devel] [PULL 2/9] usb/uas: more verbose error message, Gerd Hoffmann, 2017/02/06
- [Qemu-devel] [PULL 9/9] xhci: fix event queue IRQ handling, Gerd Hoffmann, 2017/02/06
- Re: [Qemu-devel] [PULL 0/9] usb: various bugfixes, mostly xhci., no-reply, 2017/02/06
- Re: [Qemu-devel] [PULL 0/9] usb: various bugfixes, mostly xhci., Peter Maydell, 2017/02/06