[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] ui/vnc: Drop unused vnc_has_job() and vnc_jobs_
|
From: |
Gonglei |
|
Subject: |
Re: [Qemu-devel] [PATCH] ui/vnc: Drop unused vnc_has_job() and vnc_jobs_clear() |
|
Date: |
Mon, 6 Feb 2017 11:36:50 +0800 |
|
User-agent: |
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 |
On 2017/2/4 2:24, Peter Maydell wrote:
> The functions vnc_has_job() and vnc_jobs_clear() are
> never used; remove them.
>
> Signed-off-by: Peter Maydell <address@hidden>
> ---
>
> I last had a go at this five years ago:
> http://patchwork.ozlabs.org/patch/192335/
>
> Since then vnc_stop_worker_thread() got removed anyway in
> commit 09526058d, but the vnc_jobs_clear() function that
> it was the only caller of got left behind.
>
> vnc_has_job() has never been used by anybody, and it's
> impossible to use in a non-racy way, so drop it too.
>
> ui/vnc-jobs.h | 2 --
> ui/vnc-jobs.c | 23 -----------------------
> 2 files changed, 25 deletions(-)
Reviewed-by: Gonglei <address@hidden>