Re: [Qemu-devel] [PATCH v3 1/7] Add cfgend parameter for ARM CPU selection.

[Peter Maydell]

On 20 January 2017 at 16:30, Julian Brown <address@hidden> wrote:
> The new "cfgend" parameter can be given after the CPU name,
> e.g. "-cpu=arm926,cfgend=yes". Unlike earlier versions of the patch,
> CPU attribute parsing is left to board initialisation code: for the
> "virt" board, this was being done already, and this patch makes the
> integratorcp board init do so too.
>
> Signed-off-by: Julian Brown <address@hidden>

This is sufficiently close to OK that I'm going to fix it up
in target-arm.next. Changes I'm making:

 * use error_report_err() rather than error_report() (I suspect this
   is a conflict with some API change that landed recently)
 * move the integratorcp changes to their own patch
 * drop an unnecessary extra #include;
 * move setting of reset_sctlr above registration of cpregs
   so it actually has an effect

That last one is the important one -- otherwise reset_sctlr
has already been copied into the cpregs data and the
changes to it won't be reflected in the values used for
reset. (You currently work around this with patch 3, which
we can then drop as unnecessary.)

thanks
-- PMM