Re: [Qemu-devel] [PATCH v2] q35: Improve sample configuration files

[Andrea Bolognani]

On Thu, 2017-02-02 at 16:42 +0200, Marcel Apfelbaum wrote:
[...]
> > +[device "ich9-pcie-port-1"]
> 
> I would use the new generic root port.

This sample configuration (q35-emulated.cfg) is supposed to
match physical hardware as closely as possible, so we should
stick with ioh3420s.

[...]
> > +[device "pci.1"]
> > +  driver = "ioh3420"
> 
> Same here, maybe we can use the new generic port.

These sample configuration files (q35-virtio-*.cfg) should
probably use the generic ports instead, yes. It's just that
they were not merged yet when I started working on this :)

[...]
> > +[device "ich9-pci-bridge"]
> > +  driver = "i82801b11-bridge"
> > +  bus = "pcie.0"
> > +  addr = "1e.0"
> 
> I am not sure about having the DMI-PCI bridge "by default".
> Users can understand is actually a good idea to have it by default
> while we don't really want them to use legacy PCI devices on Q35;
> and even if so, they should use them as Integrated Endpoints.
> They don't have hotplug for the DMI-PCI bridge anyway.

Not sure about this one. It doesn't show up on my laptop,
so it's not like every single q35-based physical machine has
it. I'd be okay with dropping it, but I leave the decision
to Gerd.

[...]
> Thanks for taking your time to update the configuration files!
> Marcel
> 
> 
> I personally don't use them because every time I try, I
> find something with no config support....

Is that so? Can you please test these new ones and see
whether they work for you?

-- 
Andrea Bolognani / Red Hat / Virtualization