qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 1/1] qemu_char: socket backend: disconnect on EP


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH 1/1] qemu_char: socket backend: disconnect on EPIPE
Date: Wed, 1 Feb 2017 16:54:28 -0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1


On 01/02/2017 05:53, Daniel P. Berrange wrote:
>>  
>> +        if (ret < 0 && errno == EPIPE) {
> IMHO you should just remove "&& errno == EPIPE" and it'd be fine.

It should be errno != EAGAIN.

Paolo

>> +            if (tcp_chr_read_poll(chr) <= 0) {
>> +                tcp_chr_disconnect(chr);
>> +                return len;
>> +            } /* else let the read handler finish it properly */
>> +        }



reply via email to

[Prev in Thread] Current Thread [Next in Thread]