[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 14/15] postcopy: Check for userfault+hugepage fe
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-devel] [PATCH 14/15] postcopy: Check for userfault+hugepage feature |
Date: |
Tue, 31 Jan 2017 16:20:32 +0000 |
User-agent: |
Mutt/1.7.1 (2016-10-04) |
* Juan Quintela (address@hidden) wrote:
> "Dr. David Alan Gilbert (git)" <address@hidden> wrote:
> > From: "Dr. David Alan Gilbert" <address@hidden>
> >
> > We need extra Linux kernel support (~4.9) to support userfaults
> > on hugetlbfs; check for them.
> >
> > Signed-off-by: Dr. David Alan Gilbert <address@hidden>
>
> Reviewed-by: Juan Quintela <address@hidden>
>
>
> > migration/postcopy-ram.c | 11 +++++++++++
> > 1 file changed, 11 insertions(+)
> >
> > diff --git a/migration/postcopy-ram.c b/migration/postcopy-ram.c
> > index 6b30b43..d12dd7f 100644
> > --- a/migration/postcopy-ram.c
> > +++ b/migration/postcopy-ram.c
> > @@ -81,6 +81,17 @@ static bool ufd_version_check(int ufd)
> > return false;
> > }
> >
> > + if (getpagesize() != ram_pagesize_summary()) {
>
> I am pretty sure that I don't like ram_pagesize_summary() name. I have
> already forgot what I mean O:-)
Suggested replacements welcome!
Dave
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK
- [Qemu-devel] [PATCH 10/15] postcopy: Mask fault addresses to huge page boundary, (continued)
- [Qemu-devel] [PATCH 10/15] postcopy: Mask fault addresses to huge page boundary, Dr. David Alan Gilbert (git), 2017/01/06
- [Qemu-devel] [PATCH 11/15] postcopy: Send whole huge pages, Dr. David Alan Gilbert (git), 2017/01/06
- [Qemu-devel] [PATCH 12/15] postcopy: Allow hugepages, Dr. David Alan Gilbert (git), 2017/01/06
- [Qemu-devel] [PATCH 13/15] postcopy: Update userfaultfd.h header, Dr. David Alan Gilbert (git), 2017/01/06
- [Qemu-devel] [PATCH 14/15] postcopy: Check for userfault+hugepage feature, Dr. David Alan Gilbert (git), 2017/01/06
- [Qemu-devel] [PATCH 15/15] postcopy: Add doc about hugepages and postcopy, Dr. David Alan Gilbert (git), 2017/01/06
- Re: [Qemu-devel] [PATCH 00/15] Postcopy: Hugepage support, no-reply, 2017/01/06
- Re: [Qemu-devel] [PATCH 00/15] Postcopy: Hugepage support, no-reply, 2017/01/06