[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/3] arm: better stub version for MISMATCH_CHECK
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH 1/3] arm: better stub version for MISMATCH_CHECK |
Date: |
Fri, 27 Jan 2017 16:50:38 +0000 |
On 27 January 2017 at 16:27, Michael S. Tsirkin <address@hidden> wrote:
> stub version of MISMATCH_CHECK is empty so it's easy to misuse for
> people not building kvm on arm. Use QEMU_BUILD_BUG_ON similar to the
> non-stub version to make it easier to catch bugs.
>
> Signed-off-by: Michael S. Tsirkin <address@hidden>
> ---
> target/arm/kvm-consts.h | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/target/arm/kvm-consts.h b/target/arm/kvm-consts.h
> index a2c9518..06b6c92 100644
> --- a/target/arm/kvm-consts.h
> +++ b/target/arm/kvm-consts.h
> @@ -21,7 +21,9 @@
> #define MISMATCH_CHECK(X, Y) QEMU_BUILD_BUG_ON(X != Y)
>
> #else
> -#define MISMATCH_CHECK(X, Y)
> +
> +#define MISMATCH_CHECK(X, Y) QEMU_BUILD_BUG_ON(0)
> +
> #endif
>
> #define CP_REG_SIZE_SHIFT 52
Reviewed-by: Peter Maydell <address@hidden>
thanks
-- PMM