[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Xen-devel] Commit 3a6c9 breaks QEMU on FreeBSD/Xen
From: |
Juergen Gross |
Subject: |
Re: [Qemu-devel] [Xen-devel] Commit 3a6c9 breaks QEMU on FreeBSD/Xen |
Date: |
Fri, 27 Jan 2017 10:01:35 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 |
On 26/01/17 22:21, Peter Maydell wrote:
> On 26 January 2017 at 20:47, Peter Maydell <address@hidden> wrote:
>> On 26 January 2017 at 19:36, Stefano Stabellini <address@hidden> wrote:
>>> It should be just a matter of replacing qdev_init_nofail with something
>>> that can fail. I couldn't find a regular qdev_init that can return
>>> error, so maybe we would need to add it.
>>
>> That's just
>> object_property_set_bool(OBJECT(whatever), true, "realized", &err);
>>
>> ie "please realize the device".
>
> (PS watch out for ownership refcounting issues depending on what
> you did with parenting the device: you likely want to object_unparent()
> and then object_unref() the thing in the error-exit path. See
> qdev_device_add() for some example code, maybe.)
I'll have a try later today or early next week.
Juergen
- [Qemu-devel] Commit 3a6c9 breaks QEMU on FreeBSD/Xen, Roger Pau Monné, 2017/01/24
- Re: [Qemu-devel] Commit 3a6c9 breaks QEMU on FreeBSD/Xen, Stefano Stabellini, 2017/01/24
- Re: [Qemu-devel] Commit 3a6c9 breaks QEMU on FreeBSD/Xen, Stefano Stabellini, 2017/01/24
- Re: [Qemu-devel] Commit 3a6c9 breaks QEMU on FreeBSD/Xen, Roger Pau Monné, 2017/01/25
- Re: [Qemu-devel] [Xen-devel] Commit 3a6c9 breaks QEMU on FreeBSD/Xen, Roger Pau Monné, 2017/01/26
- Re: [Qemu-devel] [Xen-devel] Commit 3a6c9 breaks QEMU on FreeBSD/Xen, Stefano Stabellini, 2017/01/26
- Re: [Qemu-devel] [Xen-devel] Commit 3a6c9 breaks QEMU on FreeBSD/Xen, Peter Maydell, 2017/01/26
- Re: [Qemu-devel] [Xen-devel] Commit 3a6c9 breaks QEMU on FreeBSD/Xen, Peter Maydell, 2017/01/26
- Re: [Qemu-devel] [Xen-devel] Commit 3a6c9 breaks QEMU on FreeBSD/Xen,
Juergen Gross <=
Re: [Qemu-devel] Commit 3a6c9 breaks QEMU on FreeBSD/Xen, Juergen Gross, 2017/01/27