Re: [Qemu-devel] [PATCH v9 00/11] Convert msix_init() to error

[Michael S. Tsirkin]

On Tue, Jan 17, 2017 at 02:18:45PM +0800, Cao jin wrote:
> v9 changelog:
> 1. split previous patch 3 into two separate patches(3 & 4), per mst's review.

So I merged 1-3, making progress here.
I really don't like forcing all callers to check and assert on specific
return status, IMO most callers want an assert on any error so that
should be the default, and special cases (probably just vfio) will use a
version that does not assert.


> test:
> 1. make check ok.
> 2. detailed test on megasas/megasas-gen2, hcd-xhci, vmxnet3.
>    megasas/megasas-gen2(M q35...bus=pcie.0): install a distro
>    ./qemu-system-x86_64 --enable-kvm -m 1024
>    -device megasas,id=scsi0,bus=pci.0
>    -drive file=/xx/scsi-disk.img,if=none,id=drive-scsi0
>    -device 
> scsi-disk,bus=scsi0.0,channel=0,scsi-id=4,lun=0,drive=drive-scsi0,id=scsi0-4
>    -cdrom /xx/Fedora-Server-DVD-x86_64-23.iso -boot once=d --monitor stdio
> 
>     hcd-xhci: fdisk, mkfs.ext4, write file to usbstick.img
>     ./qemu-system-x86_64 -M q35 --enable-kvm -m 1024
>     -drive if=none,id=usbstick,file=/xx/usbstick.img
>     -device nec-usb-xhci,id=usb,p2=8,p3=8,bus=pcie.0
>     -device usb-storage,bus=usb.0,drive=usbstick
>     /xx/FedoraServer23-X86_64.img --monitor stdio
> 
>     vmxnet3: ping another destination belongs to host's network is ok; then
>              migrate to another qemu instance on the same host is ok. After
>              migration, ping can't work as before, out of the patchset's 
> scope,
>              it is the same issue as upstream.
>     ./qemu-system-x86_64 -M q35 --enable-kvm -m 1024
>     -netdev tap,id=mynet0 -device vmxnet3,netdev=mynet0
>     /xx/FedoraServer23-X86_64.img --monitor stdio
> 
> CC: Jiri Pirko <address@hidden>
> CC: Gerd Hoffmann <address@hidden>
> CC: Dmitry Fleytman <address@hidden>
> CC: Jason Wang <address@hidden>
> CC: Michael S. Tsirkin <address@hidden>
> CC: Hannes Reinecke <address@hidden>
> CC: Paolo Bonzini <address@hidden>
> CC: Alex Williamson <address@hidden>
> CC: Markus Armbruster <address@hidden>
> CC: Marcel Apfelbaum <address@hidden>
> 
> Cao jin (11):
>   msix: Follow CODING_STYLE
>   hcd-xhci: check & correct param before using it
>   pci: Convert msix_init() to Error and fix callers
>   msix: check msix_init's return value
>   megasas: change behaviour of msix switch
>   hcd-xhci: change behaviour of msix switch
>   megasas: undo the overwrites of msi user configuration
>   vmxnet3: fix reference leak issue
>   vmxnet3: remove unnecessary internal msix flag
>   msi_init: convert assert to return -errno
>   megasas: remove unnecessary megasas_use_msix()
> 
>  hw/block/nvme.c        |  2 +-
>  hw/misc/ivshmem.c      |  8 +++---
>  hw/net/e1000e.c        |  6 ++++-
>  hw/net/rocker/rocker.c |  9 ++++++-
>  hw/net/vmxnet3.c       | 46 +++++++++++++++------------------
>  hw/pci/msi.c           |  9 ++++---
>  hw/pci/msix.c          | 44 +++++++++++++++++++++++++++-----
>  hw/scsi/megasas.c      | 49 ++++++++++++++++++++---------------
>  hw/usb/hcd-xhci.c      | 69 
> ++++++++++++++++++++++++++++++--------------------
>  hw/vfio/pci.c          |  8 ++++--
>  hw/virtio/virtio-pci.c | 13 +++++-----
>  include/hw/pci/msix.h  |  5 ++--
>  12 files changed, 167 insertions(+), 101 deletions(-)
> 
> -- 
> 2.1.0
> 
>