Re: [Qemu-devel] [PATCH] hw/i386: check if nvdimm is enabled before plugging

[Stefan Hajnoczi]

On Fri, Jan 13, 2017 at 07:56:51PM +0800, Haozhong Zhang wrote:
> The missing of 'nvdimm' in the machine type option '-M' means NVDIMM
> is disabled. QEMU should refuse to plug any NVDIMM device in this case
> and report the misconfiguration.
> 
> Reported-by: Stefan Hajnoczi <address@hidden>
> Signed-off-by: Haozhong Zhang <address@hidden>
> Message-Id: address@hidden
> Message-Id: address@hidden
> ---
>  hw/i386/pc.c | 5 +++++
>  1 file changed, 5 insertions(+)

Michael: Please add Haozhong's comment to the commit description when
merging:

"The behavior of NVDIMM on unsupported platform (HW/FW) is vendor
specific. For some vendors, it's undefined and the platform may do
anything. Thus, I think QEMU is free to choose the implementation.
Aborting QEMU (i.e. refusing to boot) is the easiest one."

This way we have a record that the behavior is okay according to the
spec and why we chose this option.

Reviewed-by: Stefan Hajnoczi <address@hidden>

signature.asc
Description: PGP signature