[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC 09/13] numa: introduce '-numa cpu' cpu option
From: |
Igor Mammedov |
Subject: |
Re: [Qemu-devel] [RFC 09/13] numa: introduce '-numa cpu' cpu option |
Date: |
Fri, 20 Jan 2017 16:33:24 +0100 |
On Fri, 20 Jan 2017 14:40:34 +0100
Paolo Bonzini <address@hidden> wrote:
> On 18/01/2017 18:13, Igor Mammedov wrote:
> > It allows to specify mapping of a CPU to NUMA node on CLI.
> > Option should be repeated for each present/possible CPU.
> > Example for PC machine:
> > -numa node,nodeid=0 -numa node,nodeid=1 \
> > -numa cpu,socket-id=0,core-id=0,thread-id=0,node-id=0 \
> > -numa cpu,socket-id=1,core-id=0,thread-id=0,node-id=1
> >
> > Signed-off-by: Igor Mammedov <address@hidden>
>
> What about making core-id/thread-id optional, like
>
> -numa cpu,socket-id=0,node-id=0
>
> ?
>
> Also perhaps change it like this to make it less verbose and match
> "-numa node":
>
> -numa node,nodeid=0 -numa cpus,nodeid=0,socket=0 \
> -numa node,nodeid=1 -numa cpus,nodeid=1,socket=1
the reason, I've made it strict/mandatory is that it's becomes
trivial property setting and matches mandatory options for -device
x86-foo-cpu,...
we can always make it less strict afterwards but not other way around,
but I can try to make it less strict on respin.
> (Yeah, I know, bikeshedding).
>
> Paolo
- [Qemu-devel] [RFC 08/13] pc: add writeonly 'cpu' property to PCMachine, (continued)
- [Qemu-devel] [RFC 08/13] pc: add writeonly 'cpu' property to PCMachine, Igor Mammedov, 2017/01/18
- [Qemu-devel] [RFC 07/13] pc: pass apic_id to pc_find_cpu_slot() directly so lookup could be done without CPU object, Igor Mammedov, 2017/01/18
- [Qemu-devel] [RFC 09/13] numa: introduce '-numa cpu' cpu option, Igor Mammedov, 2017/01/18
- [Qemu-devel] [RFC 10/13] numa: replace cpu_index_to_socket_id() with cpu_index_to_instance_props(), Igor Mammedov, 2017/01/18
- [Qemu-devel] [RFC 11/13] numa: use new machine.cpu property with -numa cpus=... CLI, Igor Mammedov, 2017/01/18
- [Qemu-devel] [RFC 13/13] pc: cpu: make sure that cpu.node-id matches -numa mapping, Igor Mammedov, 2017/01/18
- [Qemu-devel] [RFC 12/13] pc: drop usage of legacy numa_get_node_for_cpu(), Igor Mammedov, 2017/01/18
- Re: [Qemu-devel] [RFC 00/13] numa: add '-numa cpu' option, Daniel P. Berrange, 2017/01/19
- Re: [Qemu-devel] [RFC 00/13] numa: add '-numa cpu' option, Igor Mammedov, 2017/01/20