Re: [Qemu-devel] [PULL v3 00/32] Misc patches for 2017-01-11

[no-reply]

Hi,

Your series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PULL v3 00/32] Misc patches for 2017-01-11
Message-id: address@hidden
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
b6b93c9 pc.h: move x-mach-use-reliable-get-clock compat entry to PC_COMPAT_2_8
334a546 bitmap: assert that start and nr are non negative
ca15f0d hax: add Darwin support
dedbd35 Plumb the HAXM-based hardware acceleration support
bc5f0b3 target/i386: Add Intel HAX files
8bc89e9 kvm: move cpu synchronization code
af6e0a6 KVM: PPC: eliminate unnecessary duplicate constants
6864462 ramblock-notifier: new
854cba5 char: fix ctrl-a b not working
5238a07 exec: Add missing rcu_read_unlock
094c7f3 x86: ioapic: fix fail migration when irqchip=split
5dd6f92 x86: ioapic: dump version for "info ioapic"
0e2d607 x86: ioapic: add traces for ioapic
222a3dd hxtool: emit Texinfo headings as @subsection
bad6b85 qemu-thread: fix qemu_thread_set_name() race in qemu_thread_create()
6fc3285 serial: fix memory leak in serial exit
6171f29 scsi-block: fix direction of BYTCHK test for VERIFY commands
b610013 pc: fix crash in rtc_set_memory() if initial cpu is marked as hotplugged
a176e10 acpi: filter based on CONFIG_ACPI_X86 rather than TARGET
be0a969 stubs: remove stubs/kvm.c
f8a16e6 build: remove --enable-colo/--disable-colo
4c6f898 event_notifier: cleanups around event_notifier_set_handler
ef8aaf9 stubs: move vhost stubs to stubs/vhost.o
ffa465c stubs: group all monitor_fdset_* functions in a single file
f614cc6 stubs: group stubs for user-mode emulation
0f7208d hw: move reset handlers from vl.c to hw/core
f7c2256 stubs: remove unused stub for serial_hd
a54d8ee stubs: move acpi stubs to hw/acpi
a56e2ef stubs: move smbios stubs to hw/smbios
086a2f8 stubs: merge all monitor stubs in one file, remove monitor_cur_is_qmp 
stub
9438745 smbios: filter based on CONFIG_SMBIOS rather than TARGET
1a0f59b qom: Make all interface types abstract
fa7d135 megasas: fix guest-triggered memory leak
28a4388 bugfix: vm halt when in reset looping

=== OUTPUT BEGIN ===
Checking PATCH 1/34: bugfix: vm halt when in reset looping...
Checking PATCH 2/34: megasas: fix guest-triggered memory leak...
Checking PATCH 3/34: qom: Make all interface types abstract...
WARNING: line over 80 characters
#132: FILE: tests/device-introspect-test.c:174:
+    qtest_add_func("device/introspect/abstract-interfaces", 
test_abstract_interfaces);

total: 0 errors, 1 warnings, 105 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 4/34: smbios: filter based on CONFIG_SMBIOS rather than TARGET...
Checking PATCH 5/34: stubs: merge all monitor stubs in one file, remove 
monitor_cur_is_qmp stub...
ERROR: do not initialise globals to 0 or NULL
#76: FILE: stubs/monitor.c:6:
+Monitor *cur_mon = NULL;

total: 1 errors, 0 warnings, 30 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 6/34: stubs: move smbios stubs to hw/smbios...
Checking PATCH 7/34: stubs: move acpi stubs to hw/acpi...
Checking PATCH 8/34: stubs: remove unused stub for serial_hd...
Checking PATCH 9/34: hw: move reset handlers from vl.c to hw/core...
Checking PATCH 10/34: stubs: group stubs for user-mode emulation...
Checking PATCH 11/34: stubs: group all monitor_fdset_* functions in a single 
file...
Checking PATCH 12/34: stubs: move vhost stubs to stubs/vhost.o...
Checking PATCH 13/34: event_notifier: cleanups around 
event_notifier_set_handler...
Checking PATCH 14/34: build: remove --enable-colo/--disable-colo...
Checking PATCH 15/34: stubs: remove stubs/kvm.c...
Checking PATCH 16/34: acpi: filter based on CONFIG_ACPI_X86 rather than 
TARGET...
Checking PATCH 17/34: pc: fix crash in rtc_set_memory() if initial cpu is 
marked as hotplugged...
Checking PATCH 18/34: scsi-block: fix direction of BYTCHK test for VERIFY 
commands...
Checking PATCH 19/34: serial: fix memory leak in serial exit...
Checking PATCH 20/34: qemu-thread: fix qemu_thread_set_name() race in 
qemu_thread_create()...
Checking PATCH 21/34: hxtool: emit Texinfo headings as @subsection...
Checking PATCH 22/34: x86: ioapic: add traces for ioapic...
Checking PATCH 23/34: x86: ioapic: dump version for "info ioapic"...
Checking PATCH 24/34: x86: ioapic: fix fail migration when irqchip=split...
Checking PATCH 25/34: exec: Add missing rcu_read_unlock...
Checking PATCH 26/34: char: fix ctrl-a b not working...
Checking PATCH 27/34: ramblock-notifier: new...
Checking PATCH 28/34: KVM: PPC: eliminate unnecessary duplicate constants...
Checking PATCH 29/34: kvm: move cpu synchronization code...
Checking PATCH 30/34: target/i386: Add Intel HAX files...
Checking PATCH 31/34: Plumb the HAXM-based hardware acceleration support...
Checking PATCH 32/34: hax: add Darwin support...
Checking PATCH 33/34: bitmap: assert that start and nr are non negative...
Checking PATCH 34/34: pc.h: move x-mach-use-reliable-get-clock compat entry to 
PC_COMPAT_2_8...
Use of uninitialized value in concatenation (.) or string at 
./scripts/checkpatch.pl line 2169.
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden