[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 5/5] migration: Fail migration blocker for --
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-devel] [PATCH v6 5/5] migration: Fail migration blocker for --only-migratable |
Date: |
Thu, 19 Jan 2017 19:41:27 +0000 |
User-agent: |
Mutt/1.7.1 (2016-10-04) |
* Ashijeet Acharya (address@hidden) wrote:
> migrate_add_blocker should rightly fail if the '--only-migratable'
> option was specified and the device in use should not be able to
> perform the action which results in an unmigratable VM.
>
> Make migrate_add_blocker return -EACCES in this case.
>
> Signed-off-by: Ashijeet Acharya <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
> ---
> include/migration/migration.h | 2 +-
> migration/migration.c | 7 +++++++
> 2 files changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/include/migration/migration.h b/include/migration/migration.h
> index bcbdb03..7881e89 100644
> --- a/include/migration/migration.h
> +++ b/include/migration/migration.h
> @@ -291,7 +291,7 @@ int ram_postcopy_incoming_init(MigrationIncomingState
> *mis);
> *
> * @errp - [out] The reason (if any) we cannot block migration right now.
> *
> - * @returns - 0 on success, -EBUSY on failure, with errp set.
> + * @returns - 0 on success, -EBUSY/-EACCES on failure, with errp set.
> */
> int migrate_add_blocker(Error *reason, Error **errp);
>
> diff --git a/migration/migration.c b/migration/migration.c
> index 0d88286..7dcb7d7 100644
> --- a/migration/migration.c
> +++ b/migration/migration.c
> @@ -1113,6 +1113,13 @@ static GSList *migration_blockers;
>
> int migrate_add_blocker(Error *reason, Error **errp)
> {
> + if (only_migratable) {
> + error_propagate(errp, error_copy(reason));
> + error_prepend(errp, "disallowing migration blocker "
> + "(--only_migratable) for: ");
> + return -EACCES;
> + }
> +
> if (migration_is_idle(NULL)) {
> migration_blockers = g_slist_prepend(migration_blockers, reason);
> return 0;
> --
> 2.6.2
>
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK
- Re: [Qemu-devel] [PATCH v6 1/5] block/vvfat: Remove the undesirable comment, (continued)
- [Qemu-devel] [PATCH v6 2/5] migration: Add a new option to enable only-migratable, Ashijeet Acharya, 2017/01/16
- [Qemu-devel] [PATCH v6 3/5] migration: Allow "device add" options to only add migratable devices, Ashijeet Acharya, 2017/01/16
- [Qemu-devel] [PATCH v6 4/5] migration: disallow migrate_add_blocker during migration, Ashijeet Acharya, 2017/01/16
- [Qemu-devel] [PATCH v6 5/5] migration: Fail migration blocker for --only-migratable, Ashijeet Acharya, 2017/01/16
- Re: [Qemu-devel] [PATCH v6 0/5] Introduce a new --only-migratable option, Dr. David Alan Gilbert, 2017/01/24