[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH RFC v2 06/15] vfio: ccw: register vfio_ccw to th
From: |
Dong Jia Shi |
Subject: |
Re: [Qemu-devel] [PATCH RFC v2 06/15] vfio: ccw: register vfio_ccw to the mediated device framework |
Date: |
Wed, 18 Jan 2017 10:28:58 +0800 |
User-agent: |
Mutt/1.7.0 (2016-08-17) |
* Alex Williamson <address@hidden> [2017-01-17 14:02:33 -0700]:
[...]
> > diff --git a/drivers/s390/cio/vfio_ccw_ops.c
> > b/drivers/s390/cio/vfio_ccw_ops.c
[...]
> > +static int vfio_ccw_mdev_create(struct kobject *kobj, struct mdev_device
> > *mdev)
> > +{
> > + struct vfio_ccw_private *private = dev_get_drvdata(mdev->parent->dev);
> > +
> > + /* Only support one mediated device for each physical subchannel. */
> > + if (private->mdev)
> > + return -EPERM;
> > +
> > + private->mdev = mdev;
> > + available_instances--;
>
>
> This looks racy and doesn't enforce the available instances. Should
> this maybe be an atomic_t and use atomic_dec_if_positive() to return an
> error if no instances are available?
Hi Alex,
You are right. I will fix this according to your comment.
>
>
> > +
> > + return 0;
> > +}
> > +
[...]
--
Dong Jia
- [Qemu-devel] [PATCH RFC v2 00/15] basic vfio-ccw infrastructure, Dong Jia Shi, 2017/01/12
- [Qemu-devel] [PATCH RFC v2 01/15] s390: cio: introduce cio_cancel_halt_clear, Dong Jia Shi, 2017/01/12
- [Qemu-devel] [PATCH RFC v2 02/15] s390: cio: export more interfaces, Dong Jia Shi, 2017/01/12
- [Qemu-devel] [PATCH RFC v2 03/15] vfio: ccw: define device_api strings, Dong Jia Shi, 2017/01/12
- [Qemu-devel] [PATCH RFC v2 04/15] vfio: ccw: basic implementation for vfio_ccw driver, Dong Jia Shi, 2017/01/12
- [Qemu-devel] [PATCH RFC v2 05/15] vfio: ccw: introduce ccwprogram interfaces, Dong Jia Shi, 2017/01/12
- [Qemu-devel] [PATCH RFC v2 06/15] vfio: ccw: register vfio_ccw to the mediated device framework, Dong Jia Shi, 2017/01/12
- [Qemu-devel] [PATCH RFC v2 07/15] vfio: ccw: introduce ccw_io_region, Dong Jia Shi, 2017/01/12
- [Qemu-devel] [PATCH RFC v2 08/15] vfio: ccw: handle ccw command request, Dong Jia Shi, 2017/01/12
- [Qemu-devel] [PATCH RFC v2 10/15] vfio: ccw: realize VFIO_DEVICE_RESET ioctl, Dong Jia Shi, 2017/01/12
- [Qemu-devel] [PATCH RFC v2 09/15] vfio: ccw: realize VFIO_DEVICE_GET_REGION_INFO, Dong Jia Shi, 2017/01/12
- [Qemu-devel] [PATCH RFC v2 11/15] vfio: ccw: introduce ioctls to get/set VFIO_CCW_IO_IRQ, Dong Jia Shi, 2017/01/12
- [Qemu-devel] [PATCH RFC v2 12/15] vfio: ccw: return I/O results asynchronously, Dong Jia Shi, 2017/01/12
- [Qemu-devel] [PATCH RFC v2 13/15] vfio: ccw: introduce a finite state machine, Dong Jia Shi, 2017/01/12
- [Qemu-devel] [PATCH RFC v2 14/15] docs: add documentation for vfio-ccw, Dong Jia Shi, 2017/01/12