Re: [Qemu-devel] [PATCH RFC v3 1/2] block/qapi: reduce the coupling between the bdrv_query_stats and bdrv_query_bds_stats

[Dou Liyang]

Hi Eric,

At 01/13/2017 11:00 PM, Eric Blake wrote:
> On 01/04/2017 12:58 AM, Dou Liyang wrote:
> > the bdrv_query_stats and bdrv_query_bds_stats functions need to call
> > each other, that increases the coupling. it also makes the program
> > complicated and makes some unnecessary judgements.
>
> s/judgements/judgments/ - although I wonder if 'tests' would be a
> simpler word.

Yes, it is.
I will modify it.

> > remove the call from bdrv_query_bds_stats to bdrv_query_stats, just
> > take some recursion to make it clearly.
> >
> > avoid judging whether the blk is NULL during querying the bds stats.
>
> Again, 'testing' might read nicer than 'judging'.

Yes, it is.


Thanks,
        Liyang