[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v8 10/10] megasas: remove unnecessary megasas_us
From: |
Hannes Reinecke |
Subject: |
Re: [Qemu-devel] [PATCH v8 10/10] megasas: remove unnecessary megasas_use_msix() |
Date: |
Fri, 13 Jan 2017 09:20:49 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 |
On 01/13/2017 08:12 AM, Cao jin wrote:
> Also move certain hunk above, to place msix init related code together.
>
> CC: Hannes Reinecke <address@hidden>
> CC: Paolo Bonzini <address@hidden>
> CC: Markus Armbruster <address@hidden>
> CC: Marcel Apfelbaum <address@hidden>
> CC: Michael S. Tsirkin <address@hidden>
>
> Signed-off-by: Cao jin <address@hidden>
> ---
> hw/scsi/megasas.c | 19 ++++++-------------
> 1 file changed, 6 insertions(+), 13 deletions(-)
>
> msix_init() doesn't set the MSI-X enable bit, so use msix_enabled()
> is not right here, restore the old check without the
> megasas_use_msix() wrapper.
>
Reviewed-by: Hannes Reinecke <address@hidden>
Cheers,
Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
address@hidden +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
- [Qemu-devel] [PATCH v8 00/10] Convert msix_init() to error, Cao jin, 2017/01/13
- [Qemu-devel] [PATCH v8 01/10] msix: Follow CODING_STYLE, Cao jin, 2017/01/13
- [Qemu-devel] [PATCH v8 02/10] hcd-xhci: check & correct param before using it, Cao jin, 2017/01/13
- [Qemu-devel] [PATCH v8 03/10] pci: Convert msix_init() to Error and fix callers to check it, Cao jin, 2017/01/13
- [Qemu-devel] [PATCH v8 04/10] megasas: change behaviour of msix switch, Cao jin, 2017/01/13
- [Qemu-devel] [PATCH v8 05/10] hcd-xhci: change behaviour of msix switch, Cao jin, 2017/01/13
- [Qemu-devel] [PATCH v8 06/10] megasas: undo the overwrites of msi user configuration, Cao jin, 2017/01/13
- [Qemu-devel] [PATCH v8 08/10] vmxnet3: remove unnecessary internal msix flag, Cao jin, 2017/01/13
- [Qemu-devel] [PATCH v8 07/10] vmxnet3: fix reference leak issue, Cao jin, 2017/01/13
- [Qemu-devel] [PATCH v8 10/10] megasas: remove unnecessary megasas_use_msix(), Cao jin, 2017/01/13
- [Qemu-devel] [PATCH v8 09/10] msi_init: convert assert to return -errno, Cao jin, 2017/01/13
- Re: [Qemu-devel] [PATCH v8 00/10] Convert msix_init() to error, Markus Armbruster, 2017/01/13