Re: [Qemu-devel] [PATCH v2 02/47] trace: switch io/ directory to modular trace.h file

[Daniel P. Berrange]

On Thu, Jan 12, 2017 at 09:48:20AM +0100, Paolo Bonzini wrote:
> 
> 
> On 12/01/2017 02:02, Lluís Vilanova wrote:
> > Paolo Bonzini writes:
> > [...]
> >> A weird idea: what about doing
> > 
> >>     -DGENERATED_TRACERS_H=\"hw/scsi/generated-tracers.h\"
> > 
> >> and then having
> > 
> >>      #ifdef GENERATED_TRACE_H
> >>      #include GENERATED_TRACE_H
> >>      #endif
> > 
> >> in include/trace.h?
> > 
> >> Then you can use full include path for special cases such as
> >> include/hw/xen/xen_common.h, but the common case is handled directly
> >> with just
> > 
> >>      #include "trace.h"
> > 
> >> which refers to $(srcdir)/include/trace.h? (Take the above with a grain
> >> of salt because I haven't reviewed the patches closely).
> > 
> > Feels like too much black magic to me for the benefit of a bit less typing.
> 
> It's not less typing, it's about consistency.   Includes from the
> current directory are currently included with no path.

I think I am able to workaround the problems by just renaming the
top level file to trace-root.h to avoid ambiguity. Just testing
builds now...

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://entangle-photo.org       -o-    http://search.cpan.org/~danberr/ :|