[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 qemu 0/6] Fast (de)inflating & fast live migr
From: |
no-reply |
Subject: |
Re: [Qemu-devel] [PATCH v4 qemu 0/6] Fast (de)inflating & fast live migration |
Date: |
Wed, 11 Jan 2017 01:08:52 -0800 (PST) |
Hi,
Your series seems to have some coding style problems. See output below for
more information:
Message-id: address@hidden
Subject: [Qemu-devel] [PATCH v4 qemu 0/6] Fast (de)inflating & fast live
migration
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag] patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
7e2ce67 migration: skip unused pages during live migration
687ca7e kvm.c: Add two new arch specific functions
b2682d9 bitmap: Add a new bitmap_move function
3983f00 balloon: get unused page info from guest
df86151 virtio-balloon: speed up inflating & deflating process
1a58699 virtio-balloon: update linux head file
=== OUTPUT BEGIN ===
Checking PATCH 1/6: virtio-balloon: update linux head file...
Checking PATCH 2/6: virtio-balloon: speed up inflating & deflating process...
Checking PATCH 3/6: balloon: get unused page info from guest...
ERROR: suspect code indent for conditional statements (12, 17)
#147: FILE: hw/virtio/virtio-balloon.c:430:
+ if (s->bmap_len < hdr.data_len) {
+ hdr.data_len = s->bmap_len;
total: 1 errors, 0 warnings, 344 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 4/6: bitmap: Add a new bitmap_move function...
Checking PATCH 5/6: kvm.c: Add two new arch specific functions...
Checking PATCH 6/6: migration: skip unused pages during live migration...
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden
- [Qemu-devel] [PATCH v4 qemu 0/6] Fast (de)inflating & fast live migration, Liang Li, 2017/01/11
- [Qemu-devel] [PATCH v4 qemu 1/6] virtio-balloon: update linux head file, Liang Li, 2017/01/11
- [Qemu-devel] [PATCH v4 qemu 2/6] virtio-balloon: speed up inflating & deflating process, Liang Li, 2017/01/11
- [Qemu-devel] [PATCH v4 qemu 3/6] balloon: get unused page info from guest, Liang Li, 2017/01/11
- [Qemu-devel] [PATCH v4 qemu 4/6] bitmap: Add a new bitmap_move function, Liang Li, 2017/01/11
- [Qemu-devel] [PATCH v4 qemu 5/6] kvm.c: Add two new arch specific functions, Liang Li, 2017/01/11
- [Qemu-devel] [PATCH v4 qemu 6/6] migration: skip unused pages during live migration, Liang Li, 2017/01/11
- Re: [Qemu-devel] [PATCH v4 qemu 0/6] Fast (de)inflating & fast live migration,
no-reply <=
- Re: [Qemu-devel] [PATCH v4 qemu 0/6] Fast (de)inflating & fast live migration, no-reply, 2017/01/11