[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 16/20] char: use error_report()
From: |
Marc-André Lureau |
Subject: |
[Qemu-devel] [PATCH v2 16/20] char: use error_report() |
Date: |
Tue, 10 Jan 2017 18:48:06 +0100 |
Prefer error_report() over fprintf(stderr..)
Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
---
qemu-char.c | 25 ++++++++++++++-----------
1 file changed, 14 insertions(+), 11 deletions(-)
diff --git a/qemu-char.c b/qemu-char.c
index bf04360c5b..08c2113fb2 100644
--- a/qemu-char.c
+++ b/qemu-char.c
@@ -451,8 +451,8 @@ int qemu_chr_fe_get_msgfd(CharBackend *be)
int fd;
int res = (qemu_chr_fe_get_msgfds(be, &fd, 1) == 1) ? fd : -1;
if (s && qemu_chr_replay(s)) {
- fprintf(stderr,
- "Replay: get msgfd is not supported for serial devices yet\n");
+ error_report("Replay: get msgfd is not supported "
+ "for serial devices yet");
exit(1);
}
return res;
@@ -1680,8 +1680,8 @@ static Chardev *qemu_chr_open_pty(const CharDriver
*driver,
ret->pty = g_strdup(pty_name);
ret->has_pty = true;
- fprintf(stderr, "char device redirected to %s (label %s)\n",
- pty_name, id);
+ error_report("char device redirected to %s (label %s)",
+ pty_name, id);
s = (PtyChardev *)chr;
s->ioc = QIO_CHANNEL(qio_channel_file_new_fd(master_fd));
@@ -3384,8 +3384,8 @@ static int tcp_chr_wait_connected(Chardev *chr, Error
**errp)
* in TLS and telnet cases, only wait for an accepted socket */
while (!s->ioc) {
if (s->is_listen) {
- fprintf(stderr, "QEMU waiting for connection on: %s\n",
- chr->filename);
+ error_report("QEMU waiting for connection on: %s",
+ chr->filename);
qio_channel_set_blocking(QIO_CHANNEL(s->listen_ioc), true, NULL);
tcp_chr_accept(QIO_CHANNEL(s->listen_ioc), G_IO_IN, chr);
qio_channel_set_blocking(QIO_CHANNEL(s->listen_ioc), false, NULL);
@@ -4144,16 +4144,19 @@ Chardev *qemu_chr_new_from_opts(QemuOpts *opts,
}
if (is_help_option(name)) {
- fprintf(stderr, "Available chardev backend types:\n");
+ GString *str = g_string_new("");
for (i = 0; i < ARRAY_SIZE(backends); i++) {
cd = backends[i];
if (cd) {
- fprintf(stderr, "%s\n", ChardevBackendKind_lookup[cd->kind]);
+ g_string_append_printf(str, "\n%s",
ChardevBackendKind_lookup[cd->kind]);
if (cd->alias) {
- fprintf(stderr, "%s\n", cd->alias);
+ g_string_append_printf(str, "\n%s", cd->alias);
}
}
}
+
+ error_report("Available chardev backend types: %s", str->str);
+ g_string_free(str, true);
exit(0);
}
@@ -4265,8 +4268,8 @@ Chardev *qemu_chr_new(const char *label, const char
*filename)
qemu_chr_set_feature(chr, QEMU_CHAR_FEATURE_REPLAY);
}
if (qemu_chr_replay(chr) && chr->driver->chr_ioctl) {
- fprintf(stderr,
- "Replay: ioctl is not supported for serial devices yet\n");
+ error_report("Replay: ioctl is not supported "
+ "for serial devices yet");
}
replay_register_char_driver(chr);
}
--
2.11.0
- [Qemu-devel] [PATCH v2 08/20] char: fold single-user functions in caller, (continued)
- [Qemu-devel] [PATCH v2 08/20] char: fold single-user functions in caller, Marc-André Lureau, 2017/01/10
- [Qemu-devel] [PATCH v2 09/20] char: introduce generic qemu_chr_get_kind(), Marc-André Lureau, 2017/01/10
- [Qemu-devel] [PATCH v2 10/20] char: use a feature bit for replay, Marc-André Lureau, 2017/01/10
- [Qemu-devel] [PATCH v2 07/20] char: move callbacks in CharDriver, Marc-André Lureau, 2017/01/10
- [Qemu-devel] [PATCH v2 12/20] bt: use qemu_chr_alloc(), Marc-André Lureau, 2017/01/10
- [Qemu-devel] [PATCH v2 14/20] char: rename TCPChardev and NetChardev, Marc-André Lureau, 2017/01/10
- [Qemu-devel] [PATCH v2 15/20] spice-char: improve error reporting, Marc-André Lureau, 2017/01/10
- [Qemu-devel] [PATCH v2 11/20] char: allocate CharDriverState as a single object, Marc-André Lureau, 2017/01/10
- [Qemu-devel] [PATCH v2 18/20] baum: use a common prefix for chr callbacks, Marc-André Lureau, 2017/01/10
- [Qemu-devel] [PATCH v2 17/20] gtk: overwrite the console.c char driver, Marc-André Lureau, 2017/01/10
- [Qemu-devel] [PATCH v2 16/20] char: use error_report(),
Marc-André Lureau <=
- [Qemu-devel] [PATCH v2 19/20] vc: use a common prefix for chr callbacks, Marc-André Lureau, 2017/01/10
- [Qemu-devel] [PATCH v2 13/20] char: rename CharDriverState Chardev, Marc-André Lureau, 2017/01/10
- [Qemu-devel] [PATCH v2 20/20] chardev: qom-ify, Marc-André Lureau, 2017/01/10
- Re: [Qemu-devel] [PATCH v2 00/20] chardev: qom-ify, Paolo Bonzini, 2017/01/24