[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 8/8] io: introduce a DNS resolver API
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2 8/8] io: introduce a DNS resolver API |
Date: |
Tue, 10 Jan 2017 09:01:19 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 |
On 01/09/2017 09:39 AM, Daniel P. Berrange wrote:
> Currently DNS resolution is done automatically as part
> of the creation of a QIOChannelSocket object instance.
> This works ok for network clients where you just end
> up a single network socket, but for servers, the results
> of DNS resolution may require creation of multiple
> sockets.
>
> Introducing a DNS resolver API allows DNS resolution
> to be separated from the socket object creation. This
> will make it practical to create multiple QIOChannelSocket
> instances for servers.
>
> Signed-off-by: Daniel P. Berrange <address@hidden>
> ---
> include/io/dns-resolver.h | 228 +++++++++++++++++++++++++++++++++++++++
> include/qemu/sockets.h | 2 +
> io/Makefile.objs | 1 +
> io/dns-resolver.c | 267
> ++++++++++++++++++++++++++++++++++++++++++++++
> util/qemu-sockets.c | 4 +-
> 5 files changed, 500 insertions(+), 2 deletions(-)
> create mode 100644 include/io/dns-resolver.h
> create mode 100644 io/dns-resolver.c
>
> +++ b/io/dns-resolver.c
> @@ -0,0 +1,267 @@
> +/*
> + * QEMU DNS resolver
> + *
> + * Copyright (c) 2016 Red Hat, Inc.
If you want to add 2017, go for it.
Looks like you addressed everything I spotted in v1.
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v2 1/8] sockets: add ability to disable DNS resolution for InetSocketAddress, (continued)
- [Qemu-devel] [PATCH v2 1/8] sockets: add ability to disable DNS resolution for InetSocketAddress, Daniel P. Berrange, 2017/01/09
- [Qemu-devel] [PATCH v2 3/8] io: fix typo in docs for QIOTask, Daniel P. Berrange, 2017/01/09
- [Qemu-devel] [PATCH v2 2/8] io: stop incrementing reference in qio_task_get_source, Daniel P. Berrange, 2017/01/09
- [Qemu-devel] [PATCH v2 4/8] io: add ability to associate an opaque "result" with with a task, Daniel P. Berrange, 2017/01/09
- [Qemu-devel] [PATCH v2 5/8] io: add ability to associate an error with a task, Daniel P. Berrange, 2017/01/09
- [Qemu-devel] [PATCH v2 7/8] io: remove Error parameter from QIOTask thread worker, Daniel P. Berrange, 2017/01/09
- [Qemu-devel] [PATCH v2 6/8] io: change the QIOTask callback signature, Daniel P. Berrange, 2017/01/09
- [Qemu-devel] [PATCH v2 8/8] io: introduce a DNS resolver API, Daniel P. Berrange, 2017/01/09
- Re: [Qemu-devel] [PATCH v2 8/8] io: introduce a DNS resolver API,
Eric Blake <=