[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v7 00/10] Convert msix_init() to error
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH v7 00/10] Convert msix_init() to error |
Date: |
Mon, 9 Jan 2017 23:45:27 +0200 |
On Mon, Nov 14, 2016 at 03:25:30PM +0800, Cao jin wrote:
> v7 changelog:
> 1. fix the segfaut bug in patch 2. So drop the all the R-b of it,
> please take a look, there is detailed description in the patch.
> 2. add the R-b from Hannes Reinecke
>
> Test:
> 1. make check: pass
> 2. After applied all the patch, command line test for all the
> affected devices, just make sure device realize process is ok,
> no crash, but no further use of device.
Consider the megasas device for example, don't you
need to test that the change actually does what
it's intended to do?
> CC: Jiri Pirko <address@hidden>
> CC: Gerd Hoffmann <address@hidden>
> CC: Dmitry Fleytman <address@hidden>
> CC: Jason Wang <address@hidden>
> CC: Michael S. Tsirkin <address@hidden>
> CC: Hannes Reinecke <address@hidden>
> CC: Paolo Bonzini <address@hidden>
> CC: Alex Williamson <address@hidden>
> CC: Markus Armbruster <address@hidden>
> CC: Marcel Apfelbaum <address@hidden>
>
> Cao jin (10):
> msix: Follow CODING_STYLE
> hcd-xhci: check & correct param before using it
> pci: Convert msix_init() to Error and fix callers to check it
> megasas: change behaviour of msix switch
> hcd-xhci: change behaviour of msix switch
> megasas: remove unnecessary megasas_use_msix()
> megasas: undo the overwrites of msi user configuration
> vmxnet3: fix reference leak issue
> vmxnet3: remove unnecessary internal msix flag
> msi_init: convert assert to return -errno
>
> hw/block/nvme.c | 5 +++-
> hw/misc/ivshmem.c | 8 +++---
> hw/net/e1000e.c | 6 ++++-
> hw/net/rocker/rocker.c | 7 ++++-
> hw/net/vmxnet3.c | 46 +++++++++++++++------------------
> hw/pci/msi.c | 9 ++++---
> hw/pci/msix.c | 42 +++++++++++++++++++++++++-----
> hw/scsi/megasas.c | 49 ++++++++++++++++++++---------------
> hw/usb/hcd-xhci.c | 69
> ++++++++++++++++++++++++++++++--------------------
> hw/vfio/pci.c | 8 ++++--
> hw/virtio/virtio-pci.c | 11 ++++----
> include/hw/pci/msix.h | 5 ++--
> 12 files changed, 164 insertions(+), 101 deletions(-)
>
> --
> 2.1.0
>
>