Re: [Qemu-devel] [PATCH] disas/cris.c: Fix Coverity warning about unchecked NULL

[Peter Maydell]

On 9 January 2017 at 19:10,  <address@hidden> wrote:
> Checking PATCH 1/1: disas/cris.c: Fix Coverity warning about unchecked NULL...
> ERROR: code indent should never use tabs
> #24: FILE: disas/cris.c:2493:
> +^Iif (sregp == NULL || sregp->name == NULL)$
>
> ERROR: suspect code indent for conditional statements (8, 10)
> #24: FILE: disas/cris.c:2493:
> +       if (sregp == NULL || sregp->name == NULL)
>           /* Should have been caught as a non-match earlier.  */
>
> ERROR: braces {} are necessary for all arms of this statement
> #24: FILE: disas/cris.c:2493:
> +       if (sregp == NULL || sregp->name == NULL)
> [...]
>
> total: 3 errors, 0 warnings, 8 lines checked

This is because the whole file is GNU coding standards
style, being a binutils import. Better to stick with it rather
than rework, I think.

thanks
-- PMM