Re: [Qemu-devel] [PATCH 13/17] wctablet: drop DPRINTF, add trace events instead

[Eric Blake]

On 01/06/2017 02:55 AM, Gerd Hoffmann wrote:
> Signed-off-by: Gerd Hoffmann <address@hidden>
> ---
>  Makefile.objs         |  1 +
>  backends/trace-events |  8 ++++++++
>  backends/wctablet.c   | 18 +++++++-----------
>  3 files changed, 16 insertions(+), 11 deletions(-)
>  create mode 100644 backends/trace-events

Is this worth squashing into 1/17? It would be less churn, but then
diverges more from the original author's patch.


>  
> -#define DEBUG_WCTABLET_MOUSE
> -
> -#ifdef DEBUG_WCTABLET_MOUSE
> -#define DPRINTF(fmt, ...) \
> -do { fprintf(stderr, fmt , ## __VA_ARGS__); } while (0)
> -#else
> -#define DPRINTF(fmt, ...) \
> -do {} while (0)
> -#endif

I ask because I wonder if we should even (if only temporarily) have this
poor style of DPRINTF in the tree, compared to a version not prone to
bitrot (see my comments on patch 1).

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature