Re: [Qemu-devel] [PATCH] qga: fix erroneous argument to strerror

[Marc-André Lureau]

On Wed, Jan 4, 2017 at 3:54 PM Paolo Bonzini <address@hidden> wrote:

> process_command returns a negative value in case of error.  Make this
> clear in the "if" statement and fix the strerror argument to flip it
> to positive.
>
> Signed-off-by: Paolo Bonzini <address@hidden>
>


Reviewed-by: Marc-André Lureau <address@hidden>


---
>  qga/main.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/qga/main.c b/qga/main.c
> index 6caf215..538e4ee 100644
> --- a/qga/main.c
> +++ b/qga/main.c
> @@ -558,8 +558,8 @@ static void process_command(GAState *s, QDict *req)
>      rsp = qmp_dispatch(QOBJECT(req));
>      if (rsp) {
>          ret = send_response(s, rsp);
> -        if (ret) {
> -            g_warning("error sending response: %s", strerror(ret));
> +        if (ret < 0) {
> +            g_warning("error sending response: %s", strerror(-ret));
>          }
>          qobject_decref(rsp);
>      }
> --
> 2.9.3
>
>
> --
Marc-André Lureau