[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH RFC v2 04/17] intel_iommu: allocate new key when cre
From: |
Peter Xu |
Subject: |
[Qemu-devel] [PATCH RFC v2 04/17] intel_iommu: allocate new key when creating new address space |
Date: |
Tue, 3 Jan 2017 15:29:41 +0800 |
From: Jason Wang <address@hidden>
We use the pointer to stack for key for new address space, this will
break hash table searching, fixing by g_malloc() a new key instead.
Cc: Michael S. Tsirkin <address@hidden>
Cc: Paolo Bonzini <address@hidden>
Cc: Richard Henderson <address@hidden>
Cc: Eduardo Habkost <address@hidden>
Acked-by: Peter Xu <address@hidden>
Signed-off-by: Jason Wang <address@hidden>
Signed-off-by: Peter Xu <address@hidden>
---
hw/i386/intel_iommu.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c
index 6c7362a..f4d3cce 100644
--- a/hw/i386/intel_iommu.c
+++ b/hw/i386/intel_iommu.c
@@ -2327,12 +2327,13 @@ VTDAddressSpace *vtd_find_add_as(IntelIOMMUState *s,
PCIBus *bus, int devfn)
VTDAddressSpace *vtd_dev_as;
if (!vtd_bus) {
+ uintptr_t *new_key = g_malloc(sizeof(*new_key));
+ *new_key = (uintptr_t)bus;
/* No corresponding free() */
vtd_bus = g_malloc0(sizeof(VTDBus) + sizeof(VTDAddressSpace *) * \
X86_IOMMU_PCI_DEVFN_MAX);
vtd_bus->bus = bus;
- key = (uintptr_t)bus;
- g_hash_table_insert(s->vtd_as_by_busptr, &key, vtd_bus);
+ g_hash_table_insert(s->vtd_as_by_busptr, new_key, vtd_bus);
}
vtd_dev_as = vtd_bus->dev_as[devfn];
--
2.7.4
- [Qemu-devel] [PATCH RFC v2 00/17] VT-d: vfio enablement and misc enhances, Peter Xu, 2017/01/03
- [Qemu-devel] [PATCH RFC v2 01/17] IOMMU: add option to enable VTD_CAP_CM to vIOMMU capility exposoed to guest, Peter Xu, 2017/01/03
- [Qemu-devel] [PATCH RFC v2 02/17] memory: handle alias for iommu notifier, Peter Xu, 2017/01/03
- [Qemu-devel] [PATCH RFC v2 04/17] intel_iommu: allocate new key when creating new address space,
Peter Xu <=
- [Qemu-devel] [PATCH RFC v2 03/17] memory: handle alias in memory_region_is_iommu(), Peter Xu, 2017/01/03
- [Qemu-devel] [PATCH RFC v2 05/17] intel_iommu: simplify irq region translation, Peter Xu, 2017/01/03
- [Qemu-devel] [PATCH RFC v2 06/17] intel_iommu: renaming gpa to iova where proper, Peter Xu, 2017/01/03
- [Qemu-devel] [PATCH RFC v2 07/17] intel_iommu: fix trace for inv desc handling, Peter Xu, 2017/01/03
- [Qemu-devel] [PATCH RFC v2 08/17] intel_iommu: fix trace for addr translation, Peter Xu, 2017/01/03
- [Qemu-devel] [PATCH RFC v2 09/17] intel_iommu: vtd_slpt_level_shift check level, Peter Xu, 2017/01/03
- [Qemu-devel] [PATCH RFC v2 10/17] memory: add section range info for IOMMU notifier, Peter Xu, 2017/01/03
- [Qemu-devel] [PATCH RFC v2 11/17] memory: provide iommu_replay_all(), Peter Xu, 2017/01/03
- [Qemu-devel] [PATCH RFC v2 13/17] memory: add MemoryRegionIOMMUOps.replay() callback, Peter Xu, 2017/01/03
- [Qemu-devel] [PATCH RFC v2 12/17] memory: introduce memory_region_notify_one(), Peter Xu, 2017/01/03