[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL v2 09/12] target-m68k: Do not cpu_abort on undefined
From: |
Laurent Vivier |
Subject: |
[Qemu-devel] [PULL v2 09/12] target-m68k: Do not cpu_abort on undefined insns |
Date: |
Tue, 27 Dec 2016 18:53:58 +0100 |
From: Richard Henderson <address@hidden>
Report this properly via exception and, importantly, allow
the disassembler the chance to tell us what insn is not handled.
Reviewed-by: Laurent Vivier <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>
---
target/m68k/translate.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/target/m68k/translate.c b/target/m68k/translate.c
index acc8182..0417c32 100644
--- a/target/m68k/translate.c
+++ b/target/m68k/translate.c
@@ -1214,10 +1214,12 @@ DISAS_INSN(undef_fpu)
DISAS_INSN(undef)
{
- M68kCPU *cpu = m68k_env_get_cpu(env);
-
+ /* ??? This is both instructions that are as yet unimplemented
+ for the 680x0 series, as well as those that are implemented
+ but actually illegal for CPU32 or pre-68020. */
+ qemu_log_mask(LOG_UNIMP, "Illegal instruction: %04x @ %08x",
+ insn, s->pc - 2);
gen_exception(s, s->pc - 2, EXCP_UNSUPPORTED);
- cpu_abort(CPU(cpu), "Illegal instruction: %04x @ %08x", insn, s->pc - 2);
}
DISAS_INSN(mulw)
--
2.7.4
- [Qemu-devel] [PULL v2 00/12] M68k for 2.9 patches, Laurent Vivier, 2016/12/27
- [Qemu-devel] [PULL v2 04/12] target-m68k: add 64bit mull, Laurent Vivier, 2016/12/27
- [Qemu-devel] [PULL v2 06/12] target-m68k: add abcd/sbcd/nbcd, Laurent Vivier, 2016/12/27
- [Qemu-devel] [PULL v2 07/12] target-m68k: add cas/cas2 ops, Laurent Vivier, 2016/12/27
- [Qemu-devel] [PULL v2 11/12] target-m68k: add rol/ror/roxl/roxr instructions, Laurent Vivier, 2016/12/27
- [Qemu-devel] [PULL v2 12/12] target-m68k: free TCG variables that are not, Laurent Vivier, 2016/12/27
- [Qemu-devel] [PULL v2 05/12] target-m68k: add 680x0 divu/divs variants, Laurent Vivier, 2016/12/27
- [Qemu-devel] [PULL v2 02/12] target-m68k: Split gen_lea and gen_ea, Laurent Vivier, 2016/12/27
- [Qemu-devel] [PULL v2 01/12] target-m68k: Delay autoinc writeback, Laurent Vivier, 2016/12/27
- [Qemu-devel] [PULL v2 03/12] target-m68k: add cmpm, Laurent Vivier, 2016/12/27
- [Qemu-devel] [PULL v2 09/12] target-m68k: Do not cpu_abort on undefined insns,
Laurent Vivier <=
- [Qemu-devel] [PULL v2 08/12] target-m68k: Implement 680x0 movem, Laurent Vivier, 2016/12/27
- [Qemu-devel] [PULL v2 10/12] target-m68k: Inline shifts, Laurent Vivier, 2016/12/27
- Re: [Qemu-devel] [PULL v2 00/12] M68k for 2.9 patches, Peter Maydell, 2016/12/28