[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH 00/11] Stubs cleanup
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [RFC PATCH 00/11] Stubs cleanup |
Date: |
Thu, 22 Dec 2016 18:45:58 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 |
On 22/12/2016 18:42, Eduardo Habkost wrote:
> On Thu, Dec 22, 2016 at 06:32:24PM +0100, Paolo Bonzini wrote:
>>
>>
>> On 22/12/2016 18:30, Peter Maydell wrote:
>>> On 22 December 2016 at 15:59, Paolo Bonzini <address@hidden> wrote:
>>>> This moves out of libqemustub.a those functions which can be handled
>>>> simply by $(call lnot), like we already do for pci-stub.c or kvm-stub.c.
>>>> libqemustub.a keep the more complex cases where a small part of the
>>>> executables we build needs an implementation of a small subset of an API.
>>>
>>> So why is doing it this way round better? (I don't have a strong
>>> opinion here, but you don't really give a rationale for this change.)
>>
>> I don't really have a strong opinion here either, hence the RFC.
>> However, one advantage is that it keeps things visible to the right
>> maintainer.
>
> Can't we just move the files to subdirectories where they are
> visible to the maintainers, but keep using stub-obj-y/libqemustub
> to build/link them?
>
> I find libqemustub/stub-obj-y much easier to use than manually
> setting obj-$(call lnot ...).
Yes, that would work too. It's a pity that we cannot just use weak
symbols, as that would work fine with obj-y.
It would be a bit ugly to have to add "stub-obj-y += foo/" in the parent
directory. But maybe we can replace that with a "subdir-y += foo/" and
just do a single recursion for all variables. Fam, you did the current
implementation of unnest-vars, what do you think? Would it also be simpler?
Paolo
- [Qemu-devel] [PATCH 05/11] hw: move reset handlers from vl.c to hw/core, (continued)
- [Qemu-devel] [PATCH 05/11] hw: move reset handlers from vl.c to hw/core, Paolo Bonzini, 2016/12/22
- [Qemu-devel] [PATCH 06/11] stubs: group stubs for user-mode emulation, Paolo Bonzini, 2016/12/22
- [Qemu-devel] [PATCH 07/11] stubs: group all monitor_fdset_* functions in a single file, Paolo Bonzini, 2016/12/22
- [Qemu-devel] [PATCH 09/11] event_notifier: cleanups around event_notifier_set_handler, Paolo Bonzini, 2016/12/22
- [Qemu-devel] [PATCH 10/11] build: remove --enable-colo/--disable-colo, Paolo Bonzini, 2016/12/22
- [Qemu-devel] [PATCH 11/11] stubs: remove stubs/kvm.c, Paolo Bonzini, 2016/12/22
- [Qemu-devel] [PATCH 08/11] stubs: move vhost stubs to stubs/vhost.o, Paolo Bonzini, 2016/12/22
- Re: [Qemu-devel] [RFC PATCH 00/11] Stubs cleanup, Peter Maydell, 2016/12/22