Re: [Qemu-devel] [PATCH RESEND 3/5] virtio-crypto-pci: add check for cryptodev object

[Gonglei (Arei)]

>
> Subject: [PATCH RESEND 3/5] virtio-crypto-pci: add check for cryptodev object
> 
> We must assure each virtio crypto pci device has
> an invaild cryptodev backend object.
> 
Oops, a typo.

s/an invalid/ a valid/

Michael, can you pls correct it if no other comments?

Thanks,
-Gonglei

> Signed-off-by: Gonglei <address@hidden>
> ---
>  hw/virtio/virtio-crypto-pci.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/hw/virtio/virtio-crypto-pci.c b/hw/virtio/virtio-crypto-pci.c
> index a1b0906..14bd12c 100644
> --- a/hw/virtio/virtio-crypto-pci.c
> +++ b/hw/virtio/virtio-crypto-pci.c
> @@ -31,6 +31,11 @@ static void virtio_crypto_pci_realize(VirtIOPCIProxy
> *vpci_dev, Error **errp)
>      VirtIOCryptoPCI *vcrypto = VIRTIO_CRYPTO_PCI(vpci_dev);
>      DeviceState *vdev = DEVICE(&vcrypto->vdev);
> 
> +    if (vcrypto->vdev.conf.cryptodev == NULL) {
> +        error_setg(errp, "'cryptodev' parameter expects a valid object");
> +        return;
> +    }
> +
>      qdev_set_parent_bus(vdev, BUS(&vpci_dev->bus));
>      virtio_pci_force_virtio_1(vpci_dev);
>      object_property_set_bool(OBJECT(vdev), true, "realized", errp);
> --
> 1.8.3.1
>