Re: [Qemu-devel] [PATCH v3] audio: ac97: add exit function

[Marc-André Lureau]

On Thu, Dec 15, 2016 at 5:30 AM Li Qiang <address@hidden> wrote:

> From: Li Qiang <address@hidden>
>
> Currently the ac97 device emulation doesn't have a exit function,
> hot unplug this device will leak some memory. Add a exit function to
> avoid this.
>
> Signed-off-by: Li Qiang <address@hidden>
>


Reviewed-by: Marc-André Lureau <address@hidden>



> ---
>
> Changes since the v2:
> take out of the null check
>
> Changes since the v1:
> close the streams
>
>  hw/audio/ac97.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)
>
> diff --git a/hw/audio/ac97.c b/hw/audio/ac97.c
> index cbd959e..c306575 100644
> --- a/hw/audio/ac97.c
> +++ b/hw/audio/ac97.c
> @@ -1387,6 +1387,16 @@ static void ac97_realize(PCIDevice *dev, Error
> **errp)
>      ac97_on_reset (&s->dev.qdev);
>  }
>
> +static void ac97_exit(PCIDevice *dev)
> +{
> +    AC97LinkState *s = DO_UPCAST(AC97LinkState, dev, dev);
> +
> +    AUD_close_in(&s->card, s->voice_pi);
> +    AUD_close_out(&s->card, s->voice_po);
> +    AUD_close_in(&s->card, s->voice_mc);
> +    AUD_remove_card(&s->card);
> +}
> +
>  static int ac97_init (PCIBus *bus)
>  {
>      pci_create_simple (bus, -1, "AC97");
> @@ -1404,6 +1414,7 @@ static void ac97_class_init (ObjectClass *klass,
> void *data)
>      PCIDeviceClass *k = PCI_DEVICE_CLASS (klass);
>
>      k->realize = ac97_realize;
> +    k->exit = ac97_exit;
>      k->vendor_id = PCI_VENDOR_ID_INTEL;
>      k->device_id = PCI_DEVICE_ID_INTEL_82801AA_5;
>      k->revision = 0x01;
> --
> 1.8.3.1
>
> --
Marc-André Lureau