qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH for-2.8] ui/gtk: fix "Copy" menu item segfault


From: Stefan Weil
Subject: Re: [Qemu-devel] [PATCH for-2.8] ui/gtk: fix "Copy" menu item segfault
Date: Wed, 14 Dec 2016 15:35:24 +0100
User-agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1

Am 14.12.2016 um 15:25 schrieb Stefan Hajnoczi:
> The "Copy" menu item copies VTE terminal text to the clipboard.  This
> only works with VTE terminals, not with graphics consoles.
> 
> Disable the menu item when the current notebook page isn't a VTE
> terminal.
> 
> This patch fixes a segfault.  Reproducer: Start QEMU and click the Copy
> menu item when the guest display is visible.
> 
> Reported-by: Kevin Wolf <address@hidden>
> Cc: Michael S. Tsirkin <address@hidden>
> Cc: Gerd Hoffmann <address@hidden>
> Signed-off-by: Stefan Hajnoczi <address@hidden>
> ---
>  ui/gtk.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> Gerd, Michael: if you post Reviewed-by I can merge this directly without
> requiring you to send a pull request.  It's a user interface segfault so it
> would be nice to resolve it in QEMU 2.8.
> 

Tested-by: Stefan Weil <address@hidden>

CC'ing QEMU-stable because I think that 2.7 needs that fix, too.

Stefan





reply via email to

[Prev in Thread] Current Thread [Next in Thread]