[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 05/20] arm: Move CPU files to target/ folder
From: |
Thomas Huth |
Subject: |
Re: [Qemu-devel] [PATCH 05/20] arm: Move CPU files to target/ folder |
Date: |
Wed, 14 Dec 2016 08:43:25 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 |
On 13.12.2016 19:19, Peter Maydell wrote:
> On 9 December 2016 at 12:17, Thomas Huth <address@hidden> wrote:
>> diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c
>> index d4160df..60770d4 100644
>> --- a/hw/arm/virt-acpi-build.c
>> +++ b/hw/arm/virt-acpi-build.c
>> @@ -33,7 +33,7 @@
>> #include "qemu/bitmap.h"
>> #include "trace.h"
>> #include "qom/cpu.h"
>> -#include "target-arm/cpu.h"
>> +#include "cpu.h"
>> #include "hw/acpi/acpi-defs.h"
>> #include "hw/acpi/acpi.h"
>> #include "hw/nvram/fw_cfg.h"
>
> Something looks wrong here. We definitely want the ARM
> version of cpu.h, not any random cpu.h. The #include
> filename should make it clear which file we're getting,
> both so it's easier for humans to understand and so that
> one day we might be able to build more than one target
> CPU into the same QEMU binary.
Right, good catch, thanks! Looks like I did it right in the other
patches and used target/ppc/cpu.h there for example ... I'll fix it for
ARM in the next version of the patch...
Thomas
- Re: [Qemu-devel] [PATCH 01/20] Makefile: Allow CPU targets to reside in target/ folder, too, (continued)
[Qemu-devel] [PATCH 02/20] tilegx: Move CPU files to target/ folder, Thomas Huth, 2016/12/09
[Qemu-devel] [PATCH 03/20] m68k: Move CPU files to target/ folder, Thomas Huth, 2016/12/09
[Qemu-devel] [PATCH 04/20] alpha: Move CPU files to target/ folder, Thomas Huth, 2016/12/09
[Qemu-devel] [PATCH 05/20] arm: Move CPU files to target/ folder, Thomas Huth, 2016/12/09
[Qemu-devel] [PATCH 06/20] ppc: Move CPU files to target/ folder, Thomas Huth, 2016/12/09
[Qemu-devel] [PATCH 07/20] i386: Move CPU files to target/ folder, Thomas Huth, 2016/12/09
[Qemu-devel] [PATCH 08/20] microblaze: Move CPU files to target/ folder, Thomas Huth, 2016/12/09
[Qemu-devel] [PATCH 09/20] mips: Move CPU files to target/ folder, Thomas Huth, 2016/12/09
[Qemu-devel] [PATCH 10/20] s390x: Move CPU files to target/ folder, Thomas Huth, 2016/12/09