qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 20/20] Makefile.target: Targets now have to resi


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH 20/20] Makefile.target: Targets now have to reside in the target/ folder
Date: Tue, 13 Dec 2016 17:20:35 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1


On 09/12/2016 13:27, Laurent Vivier wrote:
> Le 09/12/2016 à 13:17, Thomas Huth a écrit :
>> Now that all target CPU folders have been moved to target/, we
>> do not need to support the old naming scheme of target-xxx
>> anymore.
>>
>> Signed-off-by: Thomas Huth <address@hidden>
>> ---
>>  Makefile.target | 4 ----
>>  1 file changed, 4 deletions(-)
>>
>> diff --git a/Makefile.target b/Makefile.target
>> index 90b25ae..1da789c 100644
>> --- a/Makefile.target
>> +++ b/Makefile.target
>> @@ -7,11 +7,7 @@ include config-target.mak
>>  include config-devices.mak
>>  include $(SRC_PATH)/rules.mak
>>  
>> -ifneq ($(wildcard $(SRC_PATH)/target/$(TARGET_BASE_ARCH)),)
>>  TARGET_FOLDER=target/$(TARGET_BASE_ARCH)
>> -else
>> -TARGET_FOLDER=target-$(TARGET_BASE_ARCH)
>> -endif
>>  
>>  $(call set-vpath, $(SRC_PATH):$(BUILD_DIR))
>>  ifdef CONFIG_LINUX
>>
> Reviewed-by: Laurent Vivier <address@hidden>
> 

Please undo the introduction of TARGET_FOLDER completely.

I would just squash all 20 patches together, and send a pull request.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]