Re: [Qemu-devel] [RFC v3 1/3] vhost-user: Add MTU protocol feature and op

[Maxime Coquelin]

On 11/30/2016 11:25 AM, Yuanhan Liu wrote:
> On Wed, Nov 30, 2016 at 11:10:15AM +0100, Maxime Coquelin wrote:
> > +#define VHOST_USER_PROTOCOL_F_MTU            4
> >
> >  Message types
> >  -------------
> > @@ -470,6 +471,18 @@ Message types
> >        The first 6 bytes of the payload contain the mac address of the guest to
> >        allow the vhost user backend to construct and broadcast the fake RARP.
> >
> > + * VHOST_USER_SET_MTU
>
> One thing I have just thought of is that, though we currently have one
> vhost-user driver (net), SPDK here (James cc'ed) is proposing vhost-user
> for other devices, say SCSI.
>
> So maybe it's better to add some type prefix here, like VHOST_USER_NET_SET_MTU?
Good point, and it would be consistent with the op name.

Thanks,
Maxime

>         --yliu