[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] rules.mak: Also try -r to build modules
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH] rules.mak: Also try -r to build modules |
Date: |
Tue, 29 Nov 2016 17:16:56 +0000 |
User-agent: |
Mutt/1.7.1 (2016-10-04) |
On Tue, Nov 29, 2016 at 05:57:04PM +0100, Paolo Bonzini wrote:
>
>
> On 29/11/2016 17:22, Stefan Hajnoczi wrote:
> > On Tue, Nov 29, 2016 at 04:37:20PM +0100, Paolo Bonzini wrote:
> >> Building qemu fails in distributions where gcc enables PIE by default
> >> (e.g. Debian unstable) with:
> >>
> >> /usr/bin/ld: -r and -pie may not be used together
> >>
> >> You have to use -r instead of -Wl,-r to avoid gcc passing -pie to the
> >> linker
> >> when PIE is enabled and a relocatable object is passed. However, clang
> >> does not know about -r, so try -Wl,-r first.
> >>
> >> Reported-by: Adrian Bunk <address@hidden>
> >> Cc: address@hidden
> >> Signed-off-by: Paolo Bonzini <address@hidden>
> >> ---
> >> configure | 10 ++++++++--
> >> rules.mak | 2 +-
> >> 2 files changed, 9 insertions(+), 3 deletions(-)
> >
> > Thanks, applied to my staging tree:
> > https://github.com/stefanha/qemu/commits/staging
>
> Okay, then I'll send my pull request without this one.
FWIW I applied the pull request with the broken -r fix. Then I applied
this patch on top (and added a note to the commit description explaining
this was a refinement). I've also merged your newest pull request for
-rc2.
Hopefully this got us into a more or less the state you expected? :)
Stefan
signature.asc
Description: PGP signature