qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PULL 00/11] ppc-for-2.8 queue 20161123


From: no-reply
Subject: Re: [Qemu-devel] [PULL 00/11] ppc-for-2.8 queue 20161123
Date: Tue, 22 Nov 2016 19:06:11 -0800 (PST)

Hi,

Your series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PULL 00/11] ppc-for-2.8 queue 20161123
Type: series
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
732b10b spapr: Fix 2.7<->2.8 migration of PCI host bridge
d03272e Revert "spapr: Fix migration of PCI host bridges from qemu-2.7"
8632e5b target-ppc: Allow eventual removal of old migration mistakes
2ed64f0 migration: Add VMSTATE_UINTTL_TEST()
5962a40 target-ppc: Fix CPU migration from qemu-2.6 <-> later versions
023b1c9 ppc: Make uninorth interrupt swizzling identical to Grackle
ef14b51 target-ppc: fix index array of national digits
6b3e478 hw/char/spapr_vty: Return amount of free buffer entries in 
vty_can_receive()
3714ee6 ppc: BOOK3E: nothing should be done when MSR:PR is set
2ae7725 spapr: migration support for CAS-negotiated option vectors
bf53fd9 tests/postcopy: Use KVM on ppc64 only if it is KVM-HV

=== OUTPUT BEGIN ===
Checking PATCH 1/11: tests/postcopy: Use KVM on ppc64 only if it is KVM-HV...
Checking PATCH 2/11: spapr: migration support for CAS-negotiated option 
vectors...
ERROR: spaces required around that '*' (ctx:VxV)
#99: FILE: hw/ppc/spapr.c:1347:
+    .subsections = (const VMStateDescription*[]) {
                                             ^

total: 1 errors, 0 warnings, 116 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 3/11: ppc: BOOK3E: nothing should be done when MSR:PR is set...
Checking PATCH 4/11: hw/char/spapr_vty: Return amount of free buffer entries in 
vty_can_receive()...
Checking PATCH 5/11: target-ppc: fix index array of national digits...
Checking PATCH 6/11: ppc: Make uninorth interrupt swizzling identical to 
Grackle...
Checking PATCH 7/11: target-ppc: Fix CPU migration from qemu-2.6 <-> later 
versions...
Checking PATCH 8/11: migration: Add VMSTATE_UINTTL_TEST()...
Checking PATCH 9/11: target-ppc: Allow eventual removal of old migration 
mistakes...
Checking PATCH 10/11: Revert "spapr: Fix migration of PCI host bridges from 
qemu-2.7"...
Checking PATCH 11/11: spapr: Fix 2.7<->2.8 migration of PCI host bridge...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden

reply via email to

[Prev in Thread] Current Thread [Next in Thread]